Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make final deneb changes #2729

Closed
xenowits opened this issue Nov 28, 2023 · 0 comments
Closed

make final deneb changes #2729

xenowits opened this issue Nov 28, 2023 · 0 comments
Assignees
@xenowits
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

🎯 Problem to be solved

We need to make charon deneb ready.

🛠️ Proposed solution

Although a lot of work has already been done, we need to implement the last changes to complete the deneb support work.

This include adding another case for deneb wherever we check for block version. For ex: instances where we have case eth2spec.Capella.

🧪 Tests

Test on a deneb devnet (https://notes.ethereum.org/@ethpandaops/dencun-devnet-11)
@xenowits xenowits self-assigned this Nov 28, 2023
@github-actions github-actions bot added the protocol Protocol Team tickets label Nov 28, 2023
@xenowits xenowits mentioned this issue Nov 30, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Dec 13, 2023
@xenowits
core: add deneb as default (#2734)
ad79ed6 
Add a switch case for `deneb` fork version wherever required. Also add relevant tests.

This makes `deneb` the default block version as beaconmock now uses deneb by default. This ensures all tests use deneb going forward.

category: feature 
ticket: #2729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xenowits @boulder225