Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stable feature flags #2720

Closed
3 tasks
dB2510 opened this issue Nov 20, 2023 · 0 comments · Fixed by #2735
Closed
3 tasks

Remove stable feature flags #2720

dB2510 opened this issue Nov 20, 2023 · 0 comments · Fixed by #2735
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Nov 20, 2023

🎯 Problem to be solved

We create feature flags to test our assumptions in alpha or beta environment. And we move those features to stable once we have done enough testing. We should clean feature flags that are in stable environment for a long time.

🛠️ Proposed solution

Remove feature flags which are in stable environment for a long time. These include:

  • QBFTConsensus
  • Priority
  • RelayDiscovery
  • PreGenRegistrations

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Nov 20, 2023
@dB2510 dB2510 self-assigned this Nov 30, 2023
@dB2510 dB2510 mentioned this issue Dec 1, 2023
Merged
@dB2510 dB2510 linked a pull request Dec 1, 2023 that will close this issue
featureset: remove stable feature flags #2735
Merged
obol-bulldozer bot pushed a commit that referenced this issue Dec 4, 2023
@dB2510
featureset: remove stable feature flags (#2735)
a75d49b 
Removes feature flags from feature set with stable status.

category: misc
ticket: #2720
xenowits pushed a commit that referenced this issue Dec 12, 2023
@dB2510 @xenowits
featureset: remove stable feature flags (#2735)
8d48b41 
Removes feature flags from feature set with stable status.

category: misc
ticket: #2720
gsora pushed a commit that referenced this issue Dec 21, 2023
@dB2510 @gsora
featureset: remove stable feature flags (#2735)
14883fe 
Removes feature flags from feature set with stable status.

category: misc
ticket: #2720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

featureset: remove stable feature flags ObolNetwork/charon
1 participant
@dB2510