Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modality in worklist, unable to filter #8

Closed
mtjvankuik opened this issue Mar 15, 2016 · 5 comments
Closed

Added modality in worklist, unable to filter #8

mtjvankuik opened this issue Mar 15, 2016 · 5 comments

Comments

@mtjvankuik
Copy link

I've found out that the modalities tag is empty, so filtering on modalities tag would be impossible. Therefore the modalities filter is replaced by the modality filter. I have been succesfull at loading the corresponding modality tag for each study into the worklist.

Every filter works correctly, except the (recently added) modality filter. I have tried to debug the javascript WorklistResult.js through the console window of google chrome. The filter string is added successfully when looking at local variables in console, and the same goes for loading the modality string for the corresponding study. It seems something is going wrong when comparing string A vs string B, and check whether they are identical or not.

I have added this line of code in WorklistResult.js: modality: getFilter($('input#modality').val()), //added

The filter function seems to work when debugging (I can filter on other tags, i.e. Patient Name ). My suspicions are that the fault remains in this piece of code.

    // Loop through all identified studies
    studies.forEach(function(study) {

        // Search the rest of the parameters that aren't done via the server call
        if (isIndexOf(study.modalities, modality) &&
            (new Date(studyDateFrom).setHours(0, 0, 0, 0) <= convertStringToStudyDate(study.studyDate) || !studyDateFrom || studyDateFrom === "") &&
            (convertStringToStudyDate(study.studyDate) <= new Date(studyDateTo).setHours(0, 0, 0, 0) || !studyDateTo || studyDateTo === "")) {

            // Convert numberOfStudyRelatedInstance string into integer
            study.numberOfStudyRelatedInstances = parseInt(study.numberOfStudyRelatedInstances);
            // Insert any matching studies into the WorklistStudies Collection
            WorklistStudies.insert(study);
        }
    });

    if (WorklistStudies.find().count() === 0) {
        // Show notFound text
        searchResults.showNotFoundMessage = true;
        Session.set("searchResults", searchResults);
    }`
@mtjvankuik
Copy link
Author

github_issue

@ayselafsar
Copy link
Contributor

Hi Martin,

The modality tag was not set properly in server code. I just fixed it. Could you give it a try?

@mtjvankuik
Copy link
Author

Hi ayselafsar,

I tried it but I still got a loading screen. The thing is that I use DICOM files in which the modalities tag 0008,0061 is empty. My studies consist of only 1 modality per study. Therefore I tried to replace the modalities tag with the modality tag 0008,0060. However, something is still going wrong.

I also had to add the following line of code in studies.js to be able to import the modality tag:
studies.js
function filterToQIDOURL(server, filter) { var commaSeparatedFields = [ '00081030', // Study Description '00080060' // Modality added // Add more fields here if you want them in the Study List ].join(',');

and

modality: DICOMWeb.getString(study['00080060'])

WorklistStudy.html
<td> {{modality}} </td>

WorklistResult.html
<th> <a id="_modality" class="sortingCell" href="#"> <span>Modality</span> <i class="{{sortingColumnsIcons.modality}}"></i> </a> <input type="text" class="form-control worklist-search" id="modality"> </th>

Any ideas?

@ayselafsar
Copy link
Contributor

Hi @mtjvankuik
I merged 0008,0060 - modality and 0008,0061- modalitiesInStudy tags and getting modalities tag that is shown in Study List table. Now modality is filtered between studies returned from WorklistSearch call. It works for me. Could you try again?

@mtjvankuik
Copy link
Author

Hi @ayselafsar
Thanks a lot! It is working for me as expected right now.

JamesAPetts added a commit that referenced this issue Sep 10, 2020
JamesAPetts added a commit to JamesAPetts/Viewers that referenced this issue Oct 8, 2020
* feat: 🎸 Update react-vtkjs-viewport usage to use requestPool (OHIF#1984)

* feat: 🎸 Update react-vtkjs-viewport usage to use requestPool

* Fix import of react-vtkjs-viewport to cornerstone-tools path.

* Increase maximum load time of MPR test now we are throttling requests.

* Remove debugger

Co-authored-by: Erik Ziegler <[email protected]>

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* fix: Avoid lerna:restore unless we are on Netlify (closes OHIF#1926, OHIF#1996)

* wip

* fix: Fix incorrect command name in Percy test (OHIF#1999)

* perf(stackPrefetch): Added stackPrefetch config with 20 max concurrent requests (OHIF#2000)

Co-authored-by: Danny Brown <[email protected]>

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* feat: 🎸 Filter/promote multiple series instances (OHIF#1533)

improve filter/promote to be applied on multiple series instances

✅ Closes: 1532

Co-authored-by: Rodolfo Ladeira <[email protected]>

* chore(release): publish [skip ci]

 - @ohif/[email protected]

* fix: Updated react-cornerstone-viewport to version 4.0.2 (OHIF#2001)

Co-authored-by: Danny Brown <[email protected]>

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* fix: 🐛 Fail gracefully on an MPR load error (OHIF#1992)

* feat: 🎸 Update react-vtkjs-viewport usage to use requestPool

* Fix import of react-vtkjs-viewport to cornerstone-tools path.

* Increase maximum load time of MPR test now we are throttling requests.

* fix: 🐛 Fail gracefully on an MPR load error

* Respond to reviewer comments.

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-1994] Sort series list by SeriesNumber, and sort by same SeriesNumber by date/time. (OHIF#2010)

* Sort based on SeriesNumber and SeriesDate/SeriesTime.

* Harden, and perform final sort in algorithm if last N entries have the same SeriesNumber.

* Switch to insertion rather than sorting as sorting is too slow. Reimplement low priority sorting into new insertion method.

* Fix local file viewing.

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-2017] Harden segmentation import to support more SEGs (OHIF#2024)

* fix: 🐛 Upgrade dcmjs version to support more SEGs

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-1939] Debug Dialog part 1 (OHIF#2011)

* WIP debug dialog

* Rename the p10 downloader extension to debugger extension, add button to toolbar. Deactivate it by default.

* Fix unit tests

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* IDC-1532 multiple series search google (OHIF#2026)

* Multiple series search for google cloud adapter.

* Revert IDC config.

* fix: 🐛 Series filtering on multiple series for google

* Revert changes to default config.

* Address reviewers comments.

* Fixed spelling mistakes

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* Split query parameter calls. (OHIF#2035)

* chore(release): publish [skip ci]

 - @ohif/[email protected]

* [IDC-1672] Highlight SEG segment/ RT structure when click to jump. (OHIF#2034)

* Highlight for RTSTRUCT.

* SEG temp crosshairs.

* Disable RT highlighting for now.

* Remove TODO

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-1129] - DICOM Tag Viewer extension (OHIF#2022)

* WIP render top level tags.

* Add drop down to select series.

* Fix errors with type 2 sequences.

* WIP swap instance.

* Fix formatting and make fullscreen.

* Remove debuggers.

* Finish formatting.

* Fix error with double SeriesNumber deconstruction.

* Address reviewer comments.

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-2006] - optional mailTo for debugging extension. (OHIF#2027)

* WIP debug dialog

* Rename the p10 downloader extension to debugger extension, add button to toolbar. Deactivate it by default.

* Fix unit tests

* WIP

* WIP

* Finish mailTo

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-1905] Hover tooltips for Segmentation + RTSTRUCT extension (OHIF#2044)

* WIP debug dialog

* Rename the p10 downloader extension to debugger extension, add button to toolbar. Deactivate it by default.

* Fix unit tests

* WIP

* WIP

* Finish mailTo

* tooltop

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-2049] Sort Tags in Tag browser split items in sequences, add indent after space. (OHIF#2053)

* Sort tag browser, add items, add indent.

* Remove debugger.

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* Update react-cornerstone-viewport for performance improvements (OHIF#2062)

* Update react-cornerstone-viewport

* Bump react-cornerstone-viewport version.

* Comment out tests which always cause problems.

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* [IDC-2052] PWA start url (OHIF#2070)

Change start_url in manifest.json from "./index.html" to "./"

Co-authored-by: Woonchan Cho <[email protected]>

* chore(release): publish [skip ci]

 - @ohif/[email protected]

* fix: Enable port changes for Docker image using the PORT variable (OHIF#2016)

* fix: use SeriesMetadata method instead of property in findMostRecentStructuredReport (OHIF#2038)

fixes OHIF#1714

Call getInstanceCount() instead of manually checking length (which does not work)

Co-authored-by: Stefan Silviu <[email protected]>

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

Co-authored-by: Erik Ziegler <[email protected]>
Co-authored-by: ohif-bot <[email protected]>
Co-authored-by: Alex Broaddus <[email protected]>
Co-authored-by: Danny Brown <[email protected]>
Co-authored-by: ladeirarodolfo <[email protected]>
Co-authored-by: Rodolfo Ladeira <[email protected]>
Co-authored-by: Woonchan Cho <[email protected]>
Co-authored-by: Woonchan Cho <[email protected]>
Co-authored-by: Nicolas Byl <[email protected]>
Co-authored-by: Ștefan Silviu-Alexandru <[email protected]>
Co-authored-by: Stefan Silviu <[email protected]>
pedrokohler pushed a commit to pedrokohler/ohif-viewers that referenced this issue Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants