[IDC-1672] Highlight SEG segment/ RT structure when click to jump.

[JamesAPetts]

RE: #1672

I've added temporary crosshairs that stay until you scroll/move from the segment, as discussed on a previous call.

I added highlighting for the RT contours, which we might as well keep as well, but without the crosshairs it really wasn't clear sometimes what was being highlighted.

I'd like to add highlighting for the DICOM SEG segments, but this actually isn't straight forward with the way our labelmaps currently work. We currently have each segment set at 100% opacity, and a global opacity slider, so we can't highlight one segment for a frame without changing the way our current opacity slider works. I think we can do this in a hacky way, but won't do this unless it is priority @fedorov .

We already had good indication in the MPR view with the crosshairs, so that is left as is.

Examples:

[codecov]

Codecov Report

Merging #2034 into master will decrease coverage by 5.64%.
The diff coverage is 6.38%.

@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
- Coverage   19.24%   13.60%   -5.65%     
==========================================
  Files         188      285      +97     
  Lines        5097     7387    +2290     
  Branches     1012     1395     +383     
==========================================
+ Hits          981     1005      +24     
- Misses       3292     5181    +1889     
- Partials      824     1201     +377     

Impacted Files	Coverage Δ
...atform/core/src/classes/OHIFStudyMetadataSource.js	0.00% <ø> (ø)
...latform/core/src/classes/metadata/StudyMetadata.js	1.69% <0.00%> (-0.03%)	⬇️
...atform/core/src/studies/retrieveStudiesMetadata.js	0.00% <0.00%> (ø)
...r/src/appExtensions/GenericViewerCommands/index.js	0.00% <0.00%> (ø)
...iewer/src/appExtensions/MeasurementsPanel/index.js	0.00% <0.00%> (ø)
platform/viewer/src/connectedComponents/Viewer.js	0.00% <ø> (ø)
...wer/src/connectedComponents/ViewerLocalFileData.js	0.00% <ø> (ø)
...src/connectedComponents/ViewerRetrieveStudyData.js	0.00% <0.00%> (ø)
platform/viewer/src/index.js	0.00% <0.00%> (ø)
platform/viewer/src/routes/StandaloneRouting.js	0.00% <ø> (ø)
... and 100 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48eb4a9...65b5fe6. Read the comment docs.

[fedorov]

The demo looks great - thank you @JamesAPetts! 👍

[JamesAPetts]

Awesome, glad you are happy, we'll get this after the technical review 👍.

[fedorov]

I added highlighting for the RT contours, which we might as well keep as well, but without the crosshairs it really wasn't clear sometimes what was being highlighted.

Forgot to mention - maybe we should turn off this feature. I think it is best if we keep the user experience consistent between RT and SEG, and this will add to the current divergence which we already have. If you prefer to keep it, I am fine with that, but otherwise let's turn it off.

[JamesAPetts]

Forgot to mention - maybe we should turn off this feature. I think it is best if we keep the user experience consistent between RT and SEG, and this will add to the current divergence which we already have. If you prefer to keep it, I am fine with that, but otherwise let's turn it off.

Yeah I originally started with it but it wasn't clear enough, which is why I went for crosshairs. Long term I think its beneficial, so long as we can have it for segments too, as sometimes the crosshairs aren't super clear if there are overlapping segments in the RTSTRUCT, or in the case of SEG, where the segment is an arc, not a blob (the crosshairs just point to the "center of mass" within the plane. We could also improve the latter, but its probably fine in 99% of cases for the MVP.

I'll disable it for consistency for now 👍 .

[swederik]

what is the offset for?

[JamesAPetts]

That is for drawing the crosshairs, i.e. the bit of the crosshair that "isn't drawn". It could be configurable, but its hardcoded for now.

[swederik]

I'm having deja vu here. I guess I see why this function is in both extensions though.

[JamesAPetts]

Yeah it felt bad, but the extensions should be independent. We should keep this in mind when thinking about v3 and sharing generic code snippets.