[17.0][IMP] product_main_supplierinfo: replace _get_sellers by std _get_filtered_sellers method
#1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
force-pushed
the
17-product_main_supplierinfo-imp
branch
from
e55e12a to
c0e47f7
Compare
sebalix
changed the title
_get_sellers by std _get_filtered_sellers method_get_sellers by std _get_filtered_sellers method
sebalix
force-pushed
the
17-product_main_supplierinfo-imp
branch
from
c0e47f7 to
d797363
Compare
|
Hi @xaviedoanhduy , thanks for the followup! I took your commit to replace mine here (to preserve co-authorship). |
sebalix
commented
Dec 11, 2024
|
Seems promising! |
…ed_sellers' Co-authored-by: Do Anh Duy <[email protected]>
xaviedoanhduy
force-pushed
the
17-product_main_supplierinfo-imp
branch
from
d797363 to
b76052f
Compare
|
hi @sebalix, changed according to your suggestion. |
|
@xaviedoanhduy thank you for the update, it looks good. I cannot review my own PR but I approve your changes. |
rousseldenis
approved these changes
Dec 12, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at d4582ae. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from v15, Odoo proposes the
_get_filtered_sellersmethod that could be re-used to get sellers.