Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] product_main_supplierinfo: replace _get_sellers by std _get_filtered_sellers method #1812

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[17.0][IMP] product_main_supplierinfo: replace _get_sellers by std _get_filtered_sellers method #1812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 14 additions & 26 deletions product_main_supplierinfo/models/product_product.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,31 +25,19 @@ class ProductProduct(models.Model):
)
@api.depends_context("company")
def _compute_main_seller_id(self):
for product in self:
sellers = product._get_sellers()
product.main_seller_id = fields.first(sellers)

def _get_sellers(self):
"""Returns all available sellers of a product based on some constraints.
for product in self.with_context(compute_main_seller=True):
product.main_seller_id = fields.first(
product._get_filtered_sellers(quantity=None).sorted("price")
)

They are ordered and filtered like it is done in the standard 'product' addon.
"""
self.ensure_one()
all_sellers = self._prepare_sellers(False).filtered(
lambda s: not s.company_id or s.company_id.id == self.env.company.id
)
today = fields.Date.context_today(self)
sellers = all_sellers.filtered(
lambda s: (
(s.product_id == self or not s.product_id)
and (
(s.date_start <= today if s.date_start else True)
and (s.date_end >= today if s.date_end else True)
)
def _get_filtered_sellers(
self, partner_id=False, quantity=0.0, date=None, uom_id=False, params=False
):
res = super()._get_filtered_sellers(partner_id, quantity, date, uom_id, params)
if not res and self.env.context.get("compute_main_seller"):
sellers_filtered = self._prepare_sellers(params)
sellers_filtered = sellers_filtered.filtered(
lambda s: not s.company_id or s.company_id.id == self.env.company.id
)
)
if not sellers:
sellers = all_sellers.filtered(lambda s: (s.product_id == self))
if not sellers:
sellers = all_sellers.filtered(lambda s: not s.product_id)
return sellers.sorted("price")
res = sellers_filtered.filtered(lambda s: s.product_id == self)
return res
Loading