Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] product_main_supplierinfo: Migration to 18.0 #1810

Merged
merged 14 commits into from
Dec 13, 2024

Conversation

xaviedoanhduy
Copy link

@xaviedoanhduy xaviedoanhduy commented Dec 10, 2024

base on: #1660

sebalix and others added 11 commits December 10, 2024 10:26
If no specific record are found by the first filter. The Odoo default
method will return all active supplier info.
Which will include also supplier info record related to other specific
variant.

With this change if some supplier info related to the product
variant exist, they will be returned instead.

Also add a sort on the price to have the same behaviour than on a
purchase order line for the price selected.
@xaviedoanhduy xaviedoanhduy marked this pull request as ready for review December 10, 2024 07:38
@xaviedoanhduy xaviedoanhduy mentioned this pull request Dec 10, 2024
26 tasks
Copy link
Contributor

@ajaniszewska-dev ajaniszewska-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebalix
Copy link
Contributor

sebalix commented Dec 12, 2024

@xaviedoanhduy can you cherry-pick our patch on v17 #1812 ? 🙏

@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-product_main_supplierinfo branch from 5ead75e to 2db85d1 Compare December 13, 2024 03:01
@xaviedoanhduy
Copy link
Author

@xaviedoanhduy can you cherry-pick our patch on v17 #1812 ? 🙏

hi @sebalix, done

@sebalix
Copy link
Contributor

sebalix commented Dec 13, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1810-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b4a9120 into OCA:18.0 Dec 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 73d43d4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants