[17.0][IMP] product_main_supplierinfo: replace _get_sellers by std _get_filtered_sellers method #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_sellers' Co-authored-by: Do Anh Duy <[email protected]>
xaviedoanhduy
force-pushed
the
pr_1812
branch
from
22349ca to
c5214bc
Compare
|
@xaviedoanhduy thank you, see my comments on the OCA PR. Feel free to push on my branch (so you can close this PR here), you should have write access in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting from v15, Odoo proposes the
_get_filtered_sellersmethod that could be re-used to get sellers._get_sellersis almost the same as_get_filtered_sellers, except that the following code tries to find other sellers if the above filter conditions are not satisfied, see in: https://github.com/OCA/product-attribute/blob/439e1559e873d0445c323e5a31f0360fdaa88e46/product_main_supplierinfo/models/product_product.py#L51-L52