RUC LSM update #165
Closed
RUC LSM update #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Per-file CODEOWNERS in ccpp/physics to set up automatic review requests
…OAA-EMC#440) * Remove ESMF Alarm and TimeInterval variables from module_fv3_config. * Variables nfhmax, nfhmax_hf are unused outside InitializeAdvertise. Declared them as local variables. * There is no need to keep duplicates of all time related variables in atm_int_state when we can easily access them from atm_int_state%Atm. * Remove redundant call to fms_init * Add few missing ESMF_LogFoundError checks in module_fcst_grid_comp.F90 * Delete time_utils.F90. Unused. * print only actual errors to stderr, everything else to stdout * Move realizeConnectedCplFields to module_cplfields from module_cap_cpl * Declare Atmos as module variable, and remove atmos_internalstate_wrapper * Move code from clock_cplIntval to InitializeAdvertise * Removed INTERNAL_FILE_NML from atmos_model.F90
…OAA-EMC#443) * Remove old comments from GFS_typedefs.F90. * Update logic that sets Model%cnvcld = .false.
…AA-EMC#447) * CCPP physics updates from PR NOAA-EMC#806(only diagnostic changes for RRTMGP - small diag-only RT impact for tests involving RRTMGP),NOAA-EMC#807 (only aborting model if sfc emis file not present when needed) ,NOAA-EMC#813(only SCM-specific physics changes)
…ice and NoahMP tsurf bugfix) (NOAA-EMC#452) This PR contains the ccpp physics PR NOAA-EMC#808 and NOAA-EMC#816. 808 addresses an error in the momentum roughness length over tiles with ice. 816 fixes an occasional segfault bug related to the tsurf variable in NoahMP and updates to "improve snow simulation in NoahMP for P8".
* Add 'SetRunClock' specialization routine to FV3 NUOPC cap, which sets fv3 model clock. FV3 cap does not keep local copy of clock (clock_fv3) as saved module variable anymore. * Minor code cleanup.
…-EMC#445) Clean up the exponential cloud overlapping method in RRTMG, which reflects the practice of the pre-2018 operational HWRF model.
…rtran code and CCPP metadata (NOAA-EMC#431) * Add additional diagnostic arrays for radiation-microphysics development * Bug fixes for WAM model runs with levr < levs
* Update UPP revision * Add foundation temperaure in GFS read interface for inline post.
* update submodule pointer for regression testing of ccpp-physics#812
…files (NOAA-EMC#455) * Fix uninitialized variable zmtnblck in ccpp/data/GFS_typedefs.F90 * Fix typo in CCPP standard name for ncnvwind in ccpp/data/GFS_typedefs.meta * Add ten 2d variables required for MYNNSFC restart reproducibility to ccpp/driver/GFS_restart.F90 * create initial p8 suites, P8 initial SDFs as copies of FV3_GFS_v16_coupled_nsstNoahmpUGWPv1 and FV3_GFS_v16_nsstNoahmpUGWPv1 Co-authored-by: Denise Worthen <[email protected]>
…#461) * modify FV3GFS_io.F90 by fixing errors associated with initializing snow depth over ice in the case where both land and water coexist (i.e. fractional grid case) * z0ice is changed to 1.0 cm from 1.1cm in atmos_model.F90
…nal HRRR (NOAA-EMC#457) - implements a feature of the operational HRRR, radar-derived microphysics temperature tendencies applied in the first N minutes of the forecast to improve clouds in the first few hours. * HRRR-like radar-derived temperature tendencies * Give a warning when convection is enabled with radar tten * Fix uninitialized variable zmtnblck in ccpp/data/GFS_typedefs.F90 * Add ten 2d variables required for MYNNSFC restart reproducibility to ccpp/driver/GFS_restart.F90
* Improve cloud fraction when using Thompson MP. See NCAR/ccpp-physics#809 for more details.
* Added a new suite definition file: suite_FV3_HAFS_v0_thompson_tedmf_gfdlsf.xml. This SDF is a legacy hwrf SDF but only the GFDL surface layer scheme and the Thompson scheme are kept.
…hompson MP (NOAA-EMC#462) * This PR updates the submodule pointer for ccpp-physics for the changes described in NCAR/ccpp-physics#786 (Update consistency checks and effective radii calculation for Thompson MP)
…A-EMC#466) * Unify write_netcdf and write_netcdf_parallel modules. * Add support for writing 'cubed_sphere_grid' history files in a single netcdf file * Code refactoring and cleanup.
…mework and physics (NOAA-EMC#467) *Change standard name and unit of CCPP error flag variable in CCPP framework and physics.
* Implement ESMF-managed-threading for fcstComp and wrtComp's.
*This PR addresses part 2 of CCPP issue NOAA-EMC#748 to activate the exponential-random cloud overlap method (iovr=5) in RRTMG.
* update write grid comp to have 2D decomposition on output grid. * combine PR#468: Bug fix in FV3GFS_io.F90 for allocation of temp2d Co-authored-by: Ted Mansell <[email protected]>
…(combined) (NOAA-EMC#475) * add lsm_cold_start variable in GFS_typedefs.F90/meta and update ccpp/physics for testing * includes @SMoorthi-emc 's bugfix for gwdps.f.
Update fv3 cap and write grid component to enable outputting multiple domains. This is done be creating an array of fcstGrids, and array of rout handles where each element of these arrays correspond to one atm domain. In the write grid component updates were made to allow grid spec parameters for each output grid to be specified separately. Co-authored-by: Gerhard Theurich <[email protected]>
…V3 and add the FV3_RRFS_v1alpha SDF. (NOAA-EMC#454) Adds the necessary code in fv3atm to allow for Stochastically Perturbed Parameterizations (SPP) in a set of RAP/HRRR-based physics parameterizations. Specific to the fv3atm repository, code in this PR defines the necessary variables associated with various SPP-related fields (e.g., logical to activate SPP, parameterization-specific SPP variables, etc.) that are then passed to ccpp-physics.
…sd and clm lake to quilt restart. (NOAA-EMC#660) * move utility routines, data structures, and name generation out of FV3GFS_io.F90 * move RRFS SD state restart io to separate file and rename clm_lake_io.F90 * sfc array indices are calculated in FV3GFS_sfc_io.F90 * move rrfs sd emissions input code to FV3GFS_rrfs_sd_io.F90 * allocate sfc arrays in FV3GFS_sfc_io.F90 * define and write axes in FV3GFS_sfc_io.F90 * register sfc fields in FV3GFS_sfc_io.F90 * move sfc read loop to FV3GFS_sfc_io.F90 * Put post-read safeguards in FV3GFS_sfc_io.F90 * copy to grid in FV3GFS_sfc_io.F90 and make things private * move oro reading to FV3GFS_oro_io.F90 * gwd I/O in FV3GFS_oro_io.F90 * store quilt restart data structures in FV3GFS_sfc_io types * remove copy_from_GFS_Data calls from FV3GFS_restart_io.F90 * consistent naming and clm lake quilt restart
* "for the Community Convective Cloud (c3) scheme" * "add a new SDF of FV3_HRRR_c3"
* name change for two NSSL MP namelist parameters
* add export of evap from ATM * add block_copy for special values * add 32bit physics use case for block copy
…ys that are too small (NOAA-EMC#668) * move utility routines, data structures, and name generation out of FV3GFS_io.F90 * move RRFS SD state restart io to separate file and rename clm_lake_io.F90 * move rrfs sd emissions input code to FV3GFS_rrfs_sd_io.F90 * register sfc fields in FV3GFS_sfc_io.F90 * move oro reading to FV3GFS_oro_io.F90 * gwd I/O in FV3GFS_oro_io.F90 * store quilt restart data structures in FV3GFS_sfc_io types * rrfs sd restart in quilt (still under testing) * bug fixes for RRFS 32-bit physics
* adding soil color data to NoahMP * add iopt_diag for 2m t/q diagnostic option * fixed a sfc_name2 error * fix a counting error in Sfc_io_calculate_indices
…MC#674) * optimized the code and decrease the stratosphere warm bias for mraerosol=T --------- Co-authored-by: anning.cheng <[email protected]>
* Add initialization for some local variables. * Change undefined value of aextc55 as 0 * Read soill to level 9 for RUC LSM * Correct tke reading and update upp revision. * Update upp revision to baa7751
* If the output bundle has no fields do not attempt to get a grid * Comment out return status check after recover_fields
* Add option to output top parent history file on cubed sphere grid * Rename module_configure parameter, history_file_on_native_grid
* switch sign on mean momentum fluxes * send mean momentum fluxes to mediator w/ correct sign for coupling * fix variable alignment in module_block_data * change sign of exported sensible heat flux * add evap fields for atm export * change sign for exported latent heat flux
* point to Greg's bugfix branch: few small fixes to Thompson MP
…#681) * Changes to logging and initialization of the CLM Lake Model. 1. Use ice thickness hice(i) to find the level in the lake where ice is zero. 2. Do not allow lake temperature to be below freezing point if there is no ice. 3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes. 4. Added flag to turn on debug print statements in the CLM lake model. * merge ccpp-physics NOAA-GSL#91 (UFS-SRW v3.0.0 SciDoc updates)
… & FV3_HRRR_gf (NOAA-EMC#692) * fix fortran coding error in dynamical core * use clm lake in fv3_hrrr_c3 * initialize arrays after allocation * ressurect FV3_HRRR_gf suite and give it the clm lake model * bug fix from Dusan to use the correct type kind when reading lan & lon in quilt server
…A-EMC#595) * Change the format of domain restart files to netcdf4 and set chunksizes * Remove nc_format="netcdf4" argument when opening restart files * Set chunksize of zaxis and time axis to 1 * Update clm_lake and rrfs_sd modules to support chunksizes * Make quilting restart files identical to fms files
* 2D advection of cellular automata
* update missing value * adding timing information * add write_runtimelog option * update upp and not include dycore updates that change results
* add SPP support to G-F deep convection
* MYNN SFC OpenACC directives
…nd used for data variables. (NOAA-EMC#697) * Write netcdf axis variables using the same real kind as data variables
…sics, and string length mismatch in dycore plus PR NOAA-EMC#705 and NOAA-EMC#699 (NOAA-EMC#695) * GFDL_atmos_cubed_sphere: consistent string lengths in array * stop FV3_HRRR_c3 from crashing with gnu debug * in dycore, initialize srf_wnd_var2 and tracers_var3 arrays * Write netcdf axis variables using the same real kind as data variables * "GF radar reflectivity, dust bug fix, C3 updates, more fluxes output" * Fix race condition in GFS_phys_time_vary.fv3.F90 error detection * More bug fixes to GFS_phys_time_vary.fv3.F90: 1. detect empty errmsg from subroutines 2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90 * initialize errmsg & errflg in noahmp_tables.f90 * only read h2odata, ozdata and noahmp table when they are needed * remove all constant 3D variables from clm lake * calculate clm lake constants only once per i loop --------- Co-authored-by: Dusan Jovic <[email protected]> Co-authored-by: Haiqin.Li <[email protected]>
* change mean->inst for fields going to ATM * switch 'mean' prec fields to be inst
…s. Also, output of LAI should not depend on RDLAI.
…eview and testing
42 tasks
|
You opened this PR to the wrong repository. You need to send it here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
tested on Hera
What compilers / HPCs was it tested with?
Intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes
Have the ufs-weather-model regression test been run? On what platform?
Yes, on Hera
Yes, the results for physics suites using RUC LSM will change.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first? No
If so add the "waiting for other repos" label and list the upstream PRs