2D advection of cellular automata #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
zach1221
requested review from
SadeghTabas-NOAA,
jkbk2004 and
BrianCurtis-NOAA
SadeghTabas-NOAA
approved these changes
Sep 1, 2023
BrianCurtis-NOAA
approved these changes
Sep 1, 2023
jkbk2004
approved these changes
Sep 5, 2023
|
Thanks, @jkbk2004 . This PR is now ready to merge as well. Please feel free to do so, when you're able. |
|
@BrianCurtis-NOAA can you squash/merge in? Sounds like I have a trouble to merge on my laptop now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*Add namelist ca_advect as control switch.
*Ensure the same definition for halo sizes are used in the domain construction, as when allocating data to be used in the atmospehre_scalar_field_halo routines.
*Update halo size from 1 to 3.
*Bring in U,V and control flags from FV3 to CA driver routines - compute mean level wind
*2D advection of CA cells
Issue(s) addressed
Addresses issue: ufs-community/ufs-weather-model#1869
Testing
RT tests pass on Hera (intel). Does not require new baselines.
Dependencies
Upstream PR:
NOAA-PSL/stochastic_physics#62