Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change for two NSSL MP namelist parameters #662

Merged
merged 8 commits into from
Jul 5, 2023

Conversation

JiliDong-NOAA
Copy link
Contributor

Description

This PR has two namelist parameters name changed in NSSL microphysics scheme. It includes ccpp-physics PR from @MicroTed:

ufs-community/ccpp-physics#77

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@DusanJovic-NOAA DusanJovic-NOAA changed the title name change for two NSSL MP namelist parameters Name change for two NSSL MP namelist parameters Jun 14, 2023
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jul 5, 2023

@JiliDong-NOAA ccpp pr was merged. Can you update ccpp submodule pointer and revert change in gitmodules? correct hash is ufs-community/ccpp-physics@c90c3d1

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA ccpp pr was merged. Can you update ccpp submodule pointer and revert change in gitmodules? correct hash is ufs-community/ccpp-physics@c90c3d1

done

@jkbk2004 jkbk2004 merged commit e1de62f into NOAA-EMC:develop Jul 5, 2023
@JiliDong-NOAA JiliDong-NOAA deleted the nssl_mp branch August 21, 2023 20:03
This was referenced Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants