NSSL MP update: documentation update and parameter name change #1775

JiliDong-NOAA · 2023-06-01T14:57:29Z

Description

This PR updates documentation for NSSL MP parameters and changes two parameter name.

Initialized from @MicroTed ccpp-physics PR: Update documentation for new NSSL-MP namelist parameters ccpp-physics#77

Input data additions/changes

No changes are expected to input data.
Changes are expected to input data:
- New input data.
- Updated input data.

Anticipated changes to regression tests:

No changes are expected to any regression test.
Changes are expected to the following tests:

Subcomponents involved:

Combined with PR's (If Applicable):

Commit Queue Checklist:

Link PR's from all sub-components involved in section below
Confirm reviews completed in ALL sub-component PR's
Add all appropriate labels to this PR.
Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Depends on Name change for two NSSL MP namelist parameters NOAA-EMC/fv3atm#662

Testing Day Checklist:

This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

RDHPCS
- Hera
- Orion
- Jet
- Gaea
- Cheyenne
WCOSS2
- Dogwood/Cactus
- Acorn
CI
- Completed
opnReqTest
- N/A
- Log attached to comment

grantfirl · 2023-06-16T14:50:17Z

FYI, the CCPP physics PR that this references was combined with ufs-community/ccpp-physics#76 to try to save code management work, but I'm not 100% sure that the combined PR (ufs-community/ccpp-physics#76) should go in. We either need to resolve the conversation there about its status or ask the author of ufs-community/ccpp-physics#77 to de-combine the PRs if the conversation is not resolved soon.

jkbk2004 · 2023-06-28T01:08:08Z

@JiliDong-NOAA Is regression test log available?

JiliDong-NOAA · 2023-06-28T13:08:08Z

@JiliDong-NOAA Is regression test log available?

@jkbk2004 I haven't done any regression test so far. Will start on Hera today.

jkbk2004 · 2023-06-28T14:07:31Z

@JiliDong-NOAA Is regression test log available?

@jkbk2004 I haven't done any regression test so far. Will start on Hera today.

@JiliDong-NOAA sure! go ahead to attach the log to the pr description once the test is done.

JiliDong-NOAA · 2023-06-28T16:42:42Z

@JiliDong-NOAA Is regression test log available?

@jkbk2004 I haven't done any regression test so far. Will start on Hera today.

@JiliDong-NOAA sure! go ahead to attach the log to the pr description once the test is done.

It looks like ccpp-physics in this PR is not synced with the latest commit. Should I wait for it to get synced before trying RT? @jkbk2004 @MicroTed

grantfirl · 2023-06-28T16:46:57Z

@JiliDong-NOAA Yes, I think that ufs-community/ccpp-physics#77 needs to be updated to ufs/dev before you test. If @MicroTed is unavailable to do this, you can always manually merge in ufs/dev on the machine you're using before running rt.sh.

JiliDong-NOAA · 2023-06-28T19:00:44Z

thanks @MicroTed @grantfirl . FV3 and ufs-weather-model have been synced as well. Regression tests are being running on Hera and WCOSS2. Orion is down today and I will try once it is back.

jkbk2004 · 2023-06-29T12:16:02Z

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

JiliDong-NOAA · 2023-06-29T12:39:08Z

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

it is still running. I am not sure if I use the right command: "rt.sh -l rt.conf"

JiliDong-NOAA · 2023-06-29T15:54:15Z

got an error in RT hafs_regional_1nest_atm_qr_intel

Comparing RESTART/20200825.180000.sfc_data.nc ............ALT CHECK......ERROR

this is strange as this PR shouldn't change any forecast, particularly when NSSL MP is not used. Could this be a system issue? I will run an individual RT for hafs_regional_1nest_atm_qr_intel.

JiliDong-NOAA · 2023-06-29T17:08:19Z

got an error in RT hafs_regional_1nest_atm_qr_intel

Comparing RESTART/20200825.180000.sfc_data.nc ............ALT CHECK......ERROR

this is strange as this PR shouldn't change any forecast, particularly when NSSL MP is not used. Could this be a system issue? I will run an individual RT for hafs_regional_1nest_atm_qr_intel.

The individual RT of hafs_regional_1nest_atm_qr passed OK. @jkbk2004 Is there any way to pick up from this failed RT test and resume? Restarting the whole suite of RTs will take another 20 hours to finish the first 138 RTs.

DeniseWorthen · 2023-06-29T17:13:34Z

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

it is still running. I am not sure if I use the right command: "rt.sh -l rt.conf"

@JiliDong-NOAA You did not use ecflow, which is why the test took so long. It ran each test sequentially. To run using ecflow, you need to log into the ecflow node (ssh hecflow01) and then use ./rt.sh -e -a ACCT >output 2>&1 &.

I use nems for ACCT. Yours may be different.

JiliDong-NOAA · 2023-06-29T17:15:53Z

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

it is still running. I am not sure if I use the right command: "rt.sh -l rt.conf"

@JiliDong-NOAA You did not use ecflow, which is why the test took so long. It ran each test sequentially. To run using ecflow, you need to log into the ecflow node (ssh hecflow01) and then use ./rt.sh -e -a ACCT >output 2>&1 &.

I use nems for ACCT. Yours may be different.

Ah I see. thanks @DeniseWorthen ! I will do as you suggested.

JiliDong-NOAA · 2023-06-29T19:37:57Z

RegressionTests_hera.log
RegressionTests_wcoss2.log
@jkbk2004 hera and wcoss2 rt logs uploaded.

DeniseWorthen · 2023-06-29T20:14:12Z

@JiliDong-NOAA Great. Brian tells me it is no longer required to log into an ecflow node, so you should be able to just skip that step.

JiliDong-NOAA · 2023-06-29T20:52:48Z

@JiliDong-NOAA Great. Brian tells me it is no longer required to log into an ecflow node, so you should be able to just skip that step.

Thanks again @DeniseWorthen

zach1221 · 2023-06-30T17:01:26Z

@BrianCurtis-NOAA I'm adding this PR to the commit queue, and beginning testing.

zach1221 · 2023-06-30T20:01:14Z

Jenkins-ci attached. ORTs passed.
ufs-weather-model » ort-docker-pipeline » PR-1775 #1 Console [Jenkins].pdf

zach1221 · 2023-06-30T22:39:19Z

Automated RT Failure Notification
Machine: cheyenne
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1374260656/20230630140303/ufs-weather-model
Please make changes and add the following label back: cheyenne-RT

on-behalf-of @ufs-community <[email protected]>

zach1221 · 2023-07-02T21:51:16Z

Testing is complete, we can begin the merging process. I'll follow up on the ccpp-physics sub-pr #77.

jkbk2004 · 2023-07-05T14:35:29Z

@JiliDong-NOAA fv3 pr was merged. can you update submodule pointer and revert change in gitmodiles? New fv3 hash is NOAA-EMC/fv3atm@e1de62f

JiliDong-NOAA · 2023-07-05T14:55:12Z

FV3 updated

JiliDong-NOAA added 3 commits June 1, 2023 14:44

change FV3 path

736f3cd

point FV3 to the latest commit

f7a88c1

update FV3

89e4380

update fv3atm

691086a

sync with develop

1a64178

zach1221 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jun 30, 2023

zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Jun 30, 2023

BrianCurtis-NOAA and others added 2 commits June 30, 2023 19:04

WCOSS2 RT Log

b52857a

Acorn RT Log

c3b6f78

zach1221 added cheyenne-RT hera-RT Run Hera regression testing and removed cheyenne-RT labels Jun 30, 2023

zach1221 added jet-RT Run AutoRT Jet regression testing and removed hera-RT Run Hera regression testing jet-RT Run AutoRT Jet regression testing labels Jun 30, 2023

grantfirl mentioned this pull request Jun 30, 2023

Fixed the warm bias in stratosphere from MERRA2 coupled microphysics (branch Maie) #1815

Merged

39 tasks

epic-cicd-jenkins and others added 5 commits June 30, 2023 23:12

[AutoRT] jet Job Completed.

d7daece

on-behalf-of @ufs-community <[email protected]>

[AutoRT] hera Job Completed.

291c4dc

on-behalf-of @ufs-community <[email protected]>

add orion RT logs: passed

348f119

add gaea RT logs: passed

3e0e693

add cheyenne RT logs: passed

d4ed762

zach1221 mentioned this pull request Jul 2, 2023

Update documentation for new NSSL-MP namelist parameters ufs-community/ccpp-physics#77

Merged

jkbk2004 requested review from SadeghTabas-NOAA, jkbk2004, DusanJovic-NOAA and BrianCurtis-NOAA July 5, 2023 14:36

revert fv3atm

743967b

SadeghTabas-NOAA previously approved these changes Jul 5, 2023

View reviewed changes

update FV3

0232d22

JiliDong-NOAA dismissed SadeghTabas-NOAA’s stale review via 0232d22 July 5, 2023 14:53

jkbk2004 approved these changes Jul 5, 2023

View reviewed changes

SadeghTabas-NOAA approved these changes Jul 5, 2023

View reviewed changes

jkbk2004 merged commit 24c51d1 into ufs-community:develop Jul 5, 2023

MatthewMasarik-NOAA mentioned this pull request Jul 5, 2023

Update WW3: Sync develop branch to dev/ufs-weather-model branch - 2023-jun-27 #1811

Merged

37 tasks

JiliDong-NOAA deleted the nssl_mp branch August 21, 2023 20:43

grantfirl mentioned this pull request Sep 1, 2023

UFS-dev PR#77 NCAR/ufs-weather-model#103

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NSSL MP update: documentation update and parameter name change #1775

NSSL MP update: documentation update and parameter name change #1775

JiliDong-NOAA commented Jun 1, 2023 •

edited by zach1221

Loading

grantfirl commented Jun 16, 2023

jkbk2004 commented Jun 28, 2023

JiliDong-NOAA commented Jun 28, 2023

jkbk2004 commented Jun 28, 2023

JiliDong-NOAA commented Jun 28, 2023

grantfirl commented Jun 28, 2023

JiliDong-NOAA commented Jun 28, 2023

jkbk2004 commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

DeniseWorthen commented Jun 29, 2023 •

edited

Loading

JiliDong-NOAA commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023 •

edited

Loading

DeniseWorthen commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

zach1221 commented Jun 30, 2023

zach1221 commented Jun 30, 2023

zach1221 commented Jun 30, 2023

zach1221 commented Jul 2, 2023

jkbk2004 commented Jul 5, 2023

JiliDong-NOAA commented Jul 5, 2023

NSSL MP update: documentation update and parameter name change #1775

NSSL MP update: documentation update and parameter name change #1775

Conversation

JiliDong-NOAA commented Jun 1, 2023 • edited by zach1221 Loading

Description

Input data additions/changes

Anticipated changes to regression tests:

Subcomponents involved:

Combined with PR's (If Applicable):

Commit Queue Checklist:

Linked PR's and Issues:

Testing Day Checklist:

Testing Log (for CM's):

grantfirl commented Jun 16, 2023

jkbk2004 commented Jun 28, 2023

JiliDong-NOAA commented Jun 28, 2023

jkbk2004 commented Jun 28, 2023

JiliDong-NOAA commented Jun 28, 2023

grantfirl commented Jun 28, 2023

JiliDong-NOAA commented Jun 28, 2023

jkbk2004 commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

DeniseWorthen commented Jun 29, 2023 • edited Loading

JiliDong-NOAA commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023 • edited Loading

DeniseWorthen commented Jun 29, 2023

JiliDong-NOAA commented Jun 29, 2023

zach1221 commented Jun 30, 2023

zach1221 commented Jun 30, 2023

zach1221 commented Jun 30, 2023

zach1221 commented Jul 2, 2023

jkbk2004 commented Jul 5, 2023

JiliDong-NOAA commented Jul 5, 2023

JiliDong-NOAA commented Jun 1, 2023 •

edited by zach1221

Loading

DeniseWorthen commented Jun 29, 2023 •

edited

Loading

JiliDong-NOAA commented Jun 29, 2023 •

edited

Loading