RUC LSM update #116
Merged
RUC LSM update #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. adding a heat source from fires. It is icontrolled by a flag and not turned on yet. Needs more testing. 2. Adding output of surface paramteres: leaf area index (LAI), wilting point and soil field capacity.
tanyasmirnova
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
This was referenced Oct 13, 2023
grantfirl
reviewed
Oct 18, 2023
physics/lsm_ruc.F90
Outdated
| !water and sea ice | ||
| smcref2 (i) = one | ||
| smcwlt2 (i) = zero | ||
| ! reassign smcref2 and smcwlt2 to RUC values at kdt=1 |
There was a problem hiding this comment.
Would this be clearer to put the if (kdt==1) in the else statement for if (.not. land(i))? It looks like the same thing is done for the non-land points whether or not it is the first time step.
There was a problem hiding this comment.
@grantfirl Agree, the change is made.
grantfirl
reviewed
Oct 18, 2023
physics/module_sf_ruclsm.F90
Outdated
| @@ -2049,6 +2068,9 @@ SUBROUTINE SFCTMP (debug_print, delt,ktau,conflx,i,j, & !--- input varia | |||
| eeta = eetas*(one-snowfrac) + eeta*snowfrac | |||
| qfx = qfxs*(one-snowfrac) + qfx*snowfrac | |||
| hfx = hfxs*(one-snowfrac) + hfx*snowfrac | |||
| !IF ( add_fire_heat_flux ) then ! JLS | |||
There was a problem hiding this comment.
Any reason to keep this commented-out section here and in line 2119?
There was a problem hiding this comment.
@grantfirl The commented out section is removed.
grantfirl
approved these changes
Oct 18, 2023
1. Removed commented lines in fire feedback to RUC LSM. 2. The coordinates of a test point are passed to the RUC LSM subroutines to make debug printing more manageable. 3. Reverted change in the TRANSF subroutine to original version. The non-linear root distribution needs scientific evaluation in the retro runs.
Qingfu-Liu
approved these changes
Oct 18, 2023
…hermal conductivity is made in module_sf_ruclsm.F90.
…hard snow slab thermal conductivity.
Qingfu-Liu
reviewed
Nov 2, 2023
|
@Qingfu-Liu The commented lines are removed. |
42 tasks
Also, added the fraction of grid cell that is burned out.
One more variable is added: fraction of grid cell burned by the fire. This fraction is used to take into account fire's effect on surface albedo. Also, added some debug prints. These changes will change the results only when fire feedback is turned on. The default is .false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: