[examples] Adds RockPaperScissors example #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damirka
changed the title
damirka
changed the title
awelc
previously requested changes
Mar 9, 2022
Never mind! :-) My page refreshed and I see the other file containing the test! |
lxfind
requested changes
Mar 10, 2022
sui_programmability/examples/games/tests/RockPaperScissors.move
Outdated
Show resolved
Hide resolved
sui_programmability/examples/games/sources/RockPaperScissors.move
Outdated
Show resolved
Hide resolved
lxfind
approved these changes
Mar 12, 2022
|
@awelc can you please add your review? I’m unable to merge because you requested changes before. |
|
@damirka: I think you should be able to do "dismiss review" (and this is 100% culturally acceptable) I have done this for you to unblock, but let me know if there's a permissions issue that stops you from doing this for some reason. |
huitseeker
added a commit
that referenced
this pull request
Aug 9, 2022
mwtian
pushed a commit
that referenced
this pull request
Sep 12, 2022
Context: The `BatchLoader` is establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic. The proper fix us to use the `BlockWaiter`. The issue: We would like a mitigation to be deployed and effective sooner. The fix: We inspect the worker addresses used by the `BatchLoader`, and rewrite their hostname to localhost when it matches the local primary.
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
Context: The `BatchLoader` is establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic. The proper fix us to use the `BlockWaiter`. The issue: We would like a mitigation to be deployed and effective sooner. The fix: We inspect the worker addresses used by the `BatchLoader`, and rewrite their hostname to localhost when it matches the local primary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is pretty self-explanatory. Adds an example of a game based on the commit-reveal scheme.