This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
feat: Make all Worker channels metered #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akichidis
approved these changes
Aug 8, 2022
| @@ -164,7 +162,7 @@ impl Synchronizer { | |||
|
|
|||
| // Add the digest to the waiter. | |||
| let deliver = digest; | |||
| let (tx_cancel, rx_cancel) = channel(1); | |||
| let (tx_cancel, rx_cancel) = mpsc::channel(1); | |||
There was a problem hiding this comment.
Ah probably those could be oneshot channels? (not concern of this PR of course - but something to keep in mind)
There was a problem hiding this comment.
They usually can't: this is a cancellation handler, and the branches of the tokio::select that GC and those that unpack items in waiting race each other. The GC might then try to cancel an item that's already delivered (and the delivery sinks the receiving end of the channel). With a oneshot channel, that may lead to a panic.
huitseeker
force-pushed
the
meter_worker
branch
from
b23c0a9 to
3d9a3c6
Compare
This is an extension of MystenLabs#682 to the worker
huitseeker
force-pushed
the
meter_worker
branch
from
3d9a3c6 to
f6dae11
Compare
huitseeker
added a commit
to huitseeker/narwhal
that referenced
this pull request
Aug 8, 2022
This is an extension of MystenLabs#682 to the worker
Merged
huitseeker
added a commit
that referenced
this pull request
Aug 8, 2022
This is an extension of #682 to the worker
huitseeker
added a commit
to MystenLabs/sui
that referenced
this pull request
Aug 9, 2022
huitseeker
added a commit
that referenced
this pull request
Aug 12, 2022
This is an extension of #682 to the worker
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 30, 2022
This is an extension of MystenLabs/narwhal#682 to the worker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #682 to the worker