[Build Breakage] Use new transfer_coin method in address manager. #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
666lcz
reviewed
Mar 7, 2022
| let (cert, effects, gas_used) = match wallet_context | ||
| .address_manager | ||
| .transfer_object(owner, object_id, gas_object_id, to_address) | ||
| .transfer_coin(owner, object_id, gas_object_id, to_address, tx_signer) |
There was a problem hiding this comment.
Just curious: an object can be a non-coin right? Why did we rename this method to transfer_coin then?
There was a problem hiding this comment.
No. It is not allowed to use the native transfer transaction to transfer a non-coin object.
lxfind
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Approve to unblock build break.
cc @patrickkuo to check the use of the signer
huitseeker
added a commit
that referenced
this pull request
Aug 9, 2022
mwtian
pushed a commit
that referenced
this pull request
Sep 12, 2022
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#604 was submitted without a merge to main and missed some changes to how address manager does a transfer. This will fix the breakage on main.