This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
fix: Mitigate issue #706 #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
mitigate-706
branch
from
ce0440f to
2206557
Compare
|
@huitseeker this connectivity should work as expected:
we will verify again in staging |
LefKok
approved these changes
Aug 8, 2022
gdanezis
approved these changes
Aug 8, 2022
akichidis
approved these changes
Aug 8, 2022
| @@ -169,3 +200,73 @@ impl Executor { | |||
| ]) | |||
| } | |||
| } | |||
|
|
|||
| fn replace_distant_by_localhost(target: &mut Multiaddr, hostname_pattern: &Protocol) { | |||
There was a problem hiding this comment.
Maybe logging the successful replace can give us in staging/devnet a quick feedback whether we have successfully overwritten the address
asonnino
approved these changes
Aug 8, 2022
huitseeker
force-pushed
the
mitigate-706
branch
from
2206557 to
a2a4d9c
Compare
Context: The `BatchLoader` is establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic. The proper fix us to use the `BlockWaiter`. The issue: We would like a mitigation to be deployed and effective sooner. The fix: We inspect the worker addresses used by the `BatchLoader`, and rewrite their hostname to localhost when it matches the local primary.
huitseeker
force-pushed
the
mitigate-706
branch
from
a2a4d9c to
fad675c
Compare
huitseeker
added a commit
to huitseeker/narwhal
that referenced
this pull request
Aug 8, 2022
Context: The `BatchLoader` is establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic. The proper fix us to use the `BlockWaiter`. The issue: We would like a mitigation to be deployed and effective sooner. The fix: We inspect the worker addresses used by the `BatchLoader`, and rewrite their hostname to localhost when it matches the local primary.
huitseeker
added a commit
that referenced
this pull request
Aug 8, 2022
Context: The `BatchLoader` is establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic. The proper fix us to use the `BlockWaiter`. The issue: We would like a mitigation to be deployed and effective sooner. The fix: We inspect the worker addresses used by the `BatchLoader`, and rewrite their hostname to localhost when it matches the local primary.
huitseeker
added a commit
to MystenLabs/sui
that referenced
this pull request
Aug 9, 2022
huitseeker
added a commit
that referenced
this pull request
Aug 12, 2022
Context: The `BatchLoader` is establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic. The proper fix us to use the `BlockWaiter`. The issue: We would like a mitigation to be deployed and effective sooner. The fix: We inspect the worker addresses used by the `BatchLoader`, and rewrite their hostname to localhost when it matches the local primary.
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 30, 2022
Context: The `BatchLoader` is establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic. The proper fix us to use the `BlockWaiter`. The issue: We would like a mitigation to be deployed and effective sooner. The fix: We inspect the worker addresses used by the `BatchLoader`, and rewrite their hostname to localhost when it matches the local primary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The
BatchLoaderis establishing a primary->worker communication using a public address, which is adding latency and competing with outbound traffic.The proper fix us to use the
BlockWaiter, see #706.The issue:
We would like a mitigation to be deployed and effective sooner.
The mitigation:
We inspect the worker addresses used by the
BatchLoader, and rewrite their hostname to localhost when it matches the local primary.