Set minimum Firefox version to v56.2 to support Waterfox #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum compatible version of Firefox has been lowered from `60.0` to `56.2`. It was originally set to `60.0` because that is Firefox ESR, which currently the minimum Firefox version with security updates. However Waterfox is based upon Firefox `56.0`, and has backported security fixes from the ESR release. This change in minimum version requires no additional transpiling, and doesn't affect any browser APIs we use. It does introduce one additional warning in the `addon-linter` about Firefox for Android `56` lacking support for browser action popups. However there is no version `56.2` of Firefox for Android, so the minimum version remains `57` in practice (which does support browser action popups).
|
This was motivated by this comment: #6805 (comment) |
Builds ready [14e423e]
|
Gudahtt
added a commit
that referenced
this pull request
Sep 13, 2019
The minimum compatible version of Firefox has been lowered from `60.0` to `56.2`. It was originally set to `60.0` because that is Firefox ESR, which currently the minimum Firefox version with security updates. However Waterfox is based upon Firefox `56.0`, and has backported security fixes from the ESR release. This change in minimum version requires no additional transpiling, and doesn't affect any browser APIs we use. It does introduce one additional warning in the `addon-linter` about Firefox for Android `56` lacking support for browser action popups. However there is no version `56.2` of Firefox for Android, so the minimum version remains `57` in practice (which does support browser action popups).
Gudahtt
added a commit
that referenced
this pull request
Sep 17, 2019
…evelop * origin/develop: (31 commits) Performance: Delivery optimized images (#7176) Add `appName` message to each locale Remove the disk store (#7170) Update @hapi/subtext as per security advisory (#7172) Add fixes for German translations (#7168) Fix recipient field of approve screen (#7171) 3box integration 2.0 (#6972) ci - metamaskbot - include links to dep-viz and all artifacts (#7155) Replace `undefined` selectedAddress with `null` (#7161) Add polyfill for AbortController (#7157) Remove redundant error logging (#7158) Set minimum Firefox version to v56.2 to support Waterfox (#7156) ci - install deps with "--har" flag to capture network activity (#7143) ci - create source-map-explorer build-artifacts (#7141) ci - build-artifacts - generate sesify-viz for inspecting deps (#7151) Publish GitHub release from master branch (#7136) fix rinkeby spelling (#7148) deps - move gulp-terser-js to devDeps test:integration - fix renamed test data file lint fix ...
Gudahtt
added a commit
that referenced
this pull request
Sep 27, 2019
* origin/master: Add v7.2.2 to changelog Update minimum Firefox verison to 56.0 (#7213) Version v7.2.2 Update changelog for v7.2.1, v7.2.0, and v7.1.1 Add `appName` message to each locale Version v7.2.1 Update changelog with additional bug fixes Fix recipient field of approve screen (#7171) Replace `undefined` selectedAddress with `null` (#7161) Add polyfill for AbortController (#7157) Set minimum Firefox version to v56.2 to support Waterfox (#7156) Publish GitHub release from master branch (#7136) Update the changelog for v7.1.1 (#7145) build - replace gulp-uglify-es with gulp-terser-js Version v7.2.0 Update changelog with 7.2.0 changes Allow dismissing privacy mode from popup Add changelog Version v7.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum compatible version of Firefox has been lowered from
60.0to56.2. It was originally set to60.0because that is Firefox ESR, which currently the minimum Firefox version with security updates. However Waterfox is based upon Firefox56.0, and has backported security fixes from the ESR release.This change in minimum version requires no additional transpiling, and doesn't affect any browser APIs we use.
It does introduce one additional warning in the
addon-linterabout Firefox for Android56lacking support for browser action popups. However there is no version56.2of Firefox for Android, so theminimum version remains
57in practice (which does support browser action popups).