Skip to content

Commit

Permalink
Set minimum Firefox version to v56.2 to support Waterfox (#7156)
Browse files Browse the repository at this point in the history
The minimum compatible version of Firefox has been lowered from `60.0`
to `56.2`. It was originally set to `60.0` because that is Firefox ESR,
which currently the minimum Firefox version with security updates.
However Waterfox is based upon Firefox `56.0`, and has backported
security fixes from the ESR release.

This change in minimum version requires no additional transpiling, and
doesn't affect any browser APIs we use.

It does introduce one additional warning in the `addon-linter` about
Firefox for Android `56` lacking support for browser action popups.
However there is no version `56.2` of Firefox for Android, so the
minimum version remains `57` in practice (which does support browser
action popups).
  • Loading branch information
Gudahtt authored Sep 12, 2019
1 parent dbbf698 commit 34440d6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"applications": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "60.0"
"strict_min_version": "56.2"
}
},
"default_locale": "en",
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = function (api) {
targets: {
browsers: [
'chrome >= 58',
'firefox >= 60',
'firefox >= 56.2',
],
},
},
Expand Down

0 comments on commit 34440d6

Please sign in to comment.