Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rinkeby spelling #7148

Merged
merged 1 commit into from
Sep 10, 2019
Merged

fix rinkeby spelling #7148

merged 1 commit into from
Sep 10, 2019

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks requested a review from frankiebee September 10, 2019 22:38
frankiebee
frankiebee approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💛

whymarrh
whymarrh approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@frankiebee frankiebee merged commit 38f6550 into MetaMask:develop Sep 10, 2019
Gudahtt added a commit that referenced this pull request Sep 17, 2019
@Gudahtt
Merge remote-tracking branch 'origin/develop' into sync-master-with-d…
dcc38dd 
…evelop

* origin/develop: (31 commits)
  Performance: Delivery optimized images (#7176)
  Add `appName` message to each locale
  Remove the disk store (#7170)
  Update @hapi/subtext as per security advisory (#7172)
  Add fixes for German translations (#7168)
  Fix recipient field of approve screen (#7171)
  3box integration 2.0 (#6972)
  ci - metamaskbot - include links to dep-viz and all artifacts (#7155)
  Replace `undefined` selectedAddress with `null` (#7161)
  Add polyfill for AbortController (#7157)
  Remove redundant error logging (#7158)
  Set minimum Firefox version to v56.2 to support Waterfox (#7156)
  ci - install deps with "--har" flag to capture network activity (#7143)
  ci - create source-map-explorer build-artifacts (#7141)
  ci - build-artifacts - generate sesify-viz for inspecting deps (#7151)
  Publish GitHub release from master branch (#7136)
  fix rinkeby spelling (#7148)
  deps - move gulp-terser-js to devDeps
  test:integration - fix renamed test data file
  lint fix
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankiebee frankiebee frankiebee approved these changes

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @whymarrh @frankiebee