Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipient field of approve screen #7171

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Sep 16, 2019

Fixes #7124

This fixes a bug that occured was introduced here: 789fc8b#diff-2308f22644a3fa329e9dc68f0e4aff0bR32

Before:

Screenshot from 2019-09-16 15-51-40

After:

Screenshot from 2019-09-16 15-50-52

Gudahtt
Gudahtt previously approved these changes Sep 16, 2019
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

whymarrh
whymarrh previously approved these changes Sep 16, 2019
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@danjm danjm dismissed stale reviews from whymarrh and Gudahtt via b2daa83 September 16, 2019 18:33
@danjm danjm force-pushed the approve-screen-recipient branch from e654f95 to b2daa83 Compare September 16, 2019 18:33
@danjm danjm force-pushed the approve-screen-recipient branch from b2daa83 to a42b03f Compare September 16, 2019 19:12
@metamaskbot
Copy link
Collaborator

Builds ready [a42b03f]

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danjm danjm merged commit 5641f1b into develop Sep 16, 2019
@whymarrh whymarrh deleted the approve-screen-recipient branch September 16, 2019 20:20
Gudahtt pushed a commit that referenced this pull request Sep 16, 2019
Gudahtt added a commit that referenced this pull request Sep 17, 2019
…evelop

* origin/develop: (31 commits)
  Performance: Delivery optimized images (#7176)
  Add `appName` message to each locale
  Remove the disk store (#7170)
  Update @hapi/subtext as per security advisory (#7172)
  Add fixes for German translations (#7168)
  Fix recipient field of approve screen (#7171)
  3box integration 2.0 (#6972)
  ci - metamaskbot - include links to dep-viz and all artifacts (#7155)
  Replace `undefined` selectedAddress with `null` (#7161)
  Add polyfill for AbortController (#7157)
  Remove redundant error logging (#7158)
  Set minimum Firefox version to v56.2 to support Waterfox (#7156)
  ci - install deps with "--har" flag to capture network activity (#7143)
  ci - create source-map-explorer build-artifacts (#7141)
  ci - build-artifacts - generate sesify-viz for inspecting deps (#7151)
  Publish GitHub release from master branch (#7136)
  fix rinkeby spelling (#7148)
  deps - move gulp-terser-js to devDeps
  test:integration - fix renamed test data file
  lint fix
  ...
Gudahtt added a commit that referenced this pull request Sep 27, 2019
* origin/master:
  Add v7.2.2 to changelog
  Update minimum Firefox verison to 56.0 (#7213)
  Version v7.2.2
  Update changelog for v7.2.1, v7.2.0, and v7.1.1
  Add `appName` message to each locale
  Version v7.2.1
  Update changelog with additional bug fixes
  Fix recipient field of approve screen (#7171)
  Replace `undefined` selectedAddress with `null` (#7161)
  Add polyfill for AbortController (#7157)
  Set minimum Firefox version to v56.2 to support Waterfox (#7156)
  Publish GitHub release from master branch (#7136)
  Update the changelog for v7.1.1 (#7145)
  build - replace gulp-uglify-es with gulp-terser-js
  Version v7.2.0
  Update changelog with 7.2.0 changes
  Allow dismissing privacy mode from popup
  Add changelog
  Version v7.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display contract address + identicon when giving permission to it
4 participants