Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v11.0.0 #20539

Merged
merged 34 commits into from
Sep 5, 2023
Merged

Version v11.0.0 #20539

merged 34 commits into from
Sep 5, 2023

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Aug 19, 2023

📦 🚀

danjm and others added 16 commits August 19, 2023 06:51
* [email protected]

* Update LavaMoat policies

* Add support for disabling markdown

* Update execution env URL

* Bump patch version
* Add snap legacy authorship header

* Add legacy snap header to personal_sign

* Disable SIWE for snaps

* Add comment
…20005)

* initial fixes to E2Es

* changed test website

* final E2E fixes

* fixed getentropy test

* missing scroll fix

* scrollfix for bip44 firefox

* added new function and edited tests
* Bump Snaps packages

* Add endowment:lifecycle-hooks permission

* Run yarn lint:fix

* Fix unit test

* Update LavaMoat policies

---------

Co-authored-by: MetaMask Bot <[email protected]>
* allow `SnapController` to call `SnapsRegistry:update`

* call `SnapController:updateBlockedSnaps` on extension startup

* only check if at least one snap is installed
…#20356)

* UX: Snaps: Make Notifications Font Consistent with Other Global Items

* Fix E2E
* Enable Snaps feature flag in stable

* Run snaps E2Es in stable

* Fix CI config indentation

* Fix CI paths

* Update LavaMoat policies

* Update iframe URL

* Exclude some tests from running in stable e2e

* Disable another test on stable

* Bump to 1.0.1

* Fix config.yml issue due to staleness

* Stop running newly added test

* Update snapshots used for E2E

* Use shallow-git-clone
* Track usage of snap exports

* Fix fencing

* Small change to event name

* Use MetaMetricsEventName
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm changed the base branch from develop to Version-v10.35.0 August 19, 2023 10:53
@danjm danjm marked this pull request as ready for review August 19, 2023 10:53
@danjm danjm requested review from kumavis, brad-decker and a team as code owners August 19, 2023 10:53
* Fix snaps checksums on RC

* Update protobufjs

* Update E2E snapshots

* Fix changelog lint
@socket-security
Copy link

socket-security bot commented Aug 21, 2023

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/key-tree 9.0.0 None +0 570 kB metamaskbot
@metamask/snaps-utils 0.36.1-flask.1...0.38.0-flask.1 None +2/-1 1.25 MB metamaskbot
@metamask/snaps-ui 0.36.1-flask.1...0.37.3-flask.1 None +0/-0 58.3 kB metamaskbot
@metamask/rpc-methods 0.36.1-flask.1...0.37.2-flask.1 None +3/-2 1.67 MB metamaskbot

@metamaskbot
Copy link
Collaborator

Builds ready [f104fac]
Page Load Metrics (1598 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint116201126189
domContentLoaded1488165415985225
load1488165415985225
domInteractive1488165415985225

* Fix regression in transaction confirmation tabs

* Fix transaction insights e2e test
@metamaskbot
Copy link
Collaborator

Builds ready [01a4b69]
Page Load Metrics (1945 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1231961502110
domContentLoaded1793214719449244
load1794214819459244
domInteractive1793214719449244

@FrederikBolding FrederikBolding temporarily deployed to desktop September 1, 2023 12:03 — with GitHub Actions Inactive
* Update LavaMoat policies

* Update sentry mask

* Update snapshots
@FrederikBolding FrederikBolding temporarily deployed to desktop September 1, 2023 13:51 — with GitHub Actions Inactive
@metamaskbot
Copy link
Collaborator

Builds ready [10ccbfc]
Page Load Metrics (2026 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1223291734521
domContentLoaded155527752026284136
load155527752026284136
domInteractive155527752026284136

Our logger middleware can be quite noisy in production, logging all RPC
requests. It has been updated to have more condensed logs in production
builds, but preserving the existing logging for development builds.
@FrederikBolding FrederikBolding temporarily deployed to desktop September 4, 2023 13:24 — with GitHub Actions Inactive
@metamaskbot
Copy link
Collaborator

Builds ready [da13810]
Page Load Metrics (1548 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99161118188
domContentLoaded14321989154812560
load14321989154812560
domInteractive14321975154812359

@FrederikBolding FrederikBolding temporarily deployed to desktop September 4, 2023 14:45 — with GitHub Actions Inactive
@metamaskbot
Copy link
Collaborator

Builds ready [c3da405]
Page Load Metrics (1770 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint112182141178
domContentLoaded15322051176911053
load15322052177010952
domInteractive15322051176911053

@FrederikBolding FrederikBolding temporarily deployed to desktop September 4, 2023 21:00 — with GitHub Actions Inactive
* Add what's new popup for snaps

* Update SVG

* Update copy and link out

* Update SVG and fix lint

* Fix unnecessary space in copy

---------

Co-authored-by: Howard Braham <[email protected]>
@FrederikBolding FrederikBolding temporarily deployed to desktop September 4, 2023 21:09 — with GitHub Actions Inactive
@metamaskbot
Copy link
Collaborator

Builds ready [6ac82ce]
Page Load Metrics (1725 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1081741392010
domContentLoaded14741938172511555
load14741938172511555
domInteractive14741938172511555

@FrederikBolding FrederikBolding temporarily deployed to desktop September 5, 2023 14:49 — with GitHub Actions Inactive
@metamaskbot
Copy link
Collaborator

Builds ready [6c7da3e]
Page Load Metrics (1696 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint111165135157
domContentLoaded1520192116969847
load1520192116969847
domInteractive1520192116969847

FrederikBolding and others added 2 commits September 5, 2023 19:46
* Update Snap privacy warning content

* Update unit test

* Remove translations
@FrederikBolding FrederikBolding temporarily deployed to desktop September 5, 2023 17:48 — with GitHub Actions Inactive
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This RC has been QAed by engineers on the snaps team and is good to merge.

@metamaskbot
Copy link
Collaborator

Builds ready [b72df43]
Page Load Metrics (1664 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint113172132189
domContentLoaded1510185916648340
load1510185916648440
domInteractive1509185916648340

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 75c213a into master Sep 5, 2023
10 checks passed
@Gudahtt Gudahtt deleted the Version-v11.0.0 branch September 5, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants