Reduce logging in production builds #20694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
reduce-logging-in-production-builds
branch
from
21c7a20 to
40533c5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20694 +/- ##
===========================================
- Coverage 68.82% 68.82% -0.01%
===========================================
Files 997 997
Lines 38931 38934 +3
Branches 10447 10454 +7
===========================================
Hits 26794 26794
- Misses 12137 12140 +3
☔ View full report in Codecov by Sentry. |
Builds ready [40533c5]
Page Load Metrics (1512 ± 27 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
force-pushed
the
reduce-logging-in-production-builds
branch
3 times, most recently
from
67d7cfa to
1645c41
Compare
Builds ready [1645c41]
Page Load Metrics (1590 ± 49 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Our logger middleware can be quite noisy in production, logging all RPC requests. It has been updated to have more condensed logs in production builds, but preserving the existing logging for development builds.
Gudahtt
force-pushed
the
reduce-logging-in-production-builds
branch
from
1645c41 to
e046338
Compare
metamaskbot
added
the
release-11.1.0
Builds ready [e046338]
Page Load Metrics (1755 ± 51 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
added
release-11.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Our logger middleware can be quite noisy in production, logging all RPC requests. It has been updated to have more condensed logs in production builds, but preserving the existing logging for development builds.
A few error logs in the method handling middleware have been suppressed in production as well. They were redundant anyway.
This fixes https://github.com/MetaMask/MetaMask-planning/issues/1281
Manual Testing Steps
yarn startoryarn start:test). But on non-development builds they have less detail (and there is no longer a separate log entry for errors).Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.