-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for blocked snaps on extension startup #20336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
GuillaumeRx
force-pushed
the
gr/snap-blocklist-update
branch
from
August 1, 2023 11:43
5bf2679
to
5a3e259
Compare
david0xd
previously approved these changes
Aug 1, 2023
Builds ready [5a3e259]
Page Load Metrics (1460 ± 44 ms)
Bundle size diffs
|
legobeat
previously approved these changes
Aug 2, 2023
GuillaumeRx
force-pushed
the
gr/snap-blocklist-update
branch
from
August 2, 2023 09:28
36d11db
to
6438c56
Compare
GuillaumeRx
added
the
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
label
Aug 2, 2023
david0xd
approved these changes
Aug 2, 2023
Codecov Report
@@ Coverage Diff @@
## develop #20336 +/- ##
========================================
Coverage 68.69% 68.69%
========================================
Files 990 990
Lines 38082 38082
Branches 10200 10200
========================================
Hits 26159 26159
Misses 11923 11923
|
Builds ready [6438c56]
Page Load Metrics (1474 ± 40 ms)
Bundle size diffs
|
hmalik88
approved these changes
Aug 2, 2023
metamaskbot
added
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Aug 2, 2023
Gudahtt
added
release-11.1.0
Issue or pull request that will be included in release 11.1.0
and removed
release-10.36.0
Issue or pull request that will be included in release 10.36.0
labels
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.1.0
Issue or pull request that will be included in release 11.1.0
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This calls
SnapController:updateBlockedSnaps
when the extensions starts (when the browser is opened)Manual Testing Steps