Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for blocked snaps on extension startup #20336

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Aug 1, 2023

Explanation

This calls SnapController:updateBlockedSnaps when the extensions starts (when the browser is opened)

Manual Testing Steps

  • Disable the extension in the extension page of your browser
  • Re-enable it
  • Quickly open the background inspector to the network tab
  • See that the registry has been updated

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner August 1, 2023 11:41
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GuillaumeRx GuillaumeRx force-pushed the gr/snap-blocklist-update branch from 5bf2679 to 5a3e259 Compare August 1, 2023 11:43
david0xd
david0xd previously approved these changes Aug 1, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [5a3e259]
Page Load Metrics (1460 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint108169127168
domContentLoaded1341177214609244
load1341177314609244
domInteractive1341177214609244
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

legobeat
legobeat previously approved these changes Aug 2, 2023
@GuillaumeRx GuillaumeRx dismissed stale reviews from legobeat and david0xd via 36d11db August 2, 2023 09:27
@GuillaumeRx GuillaumeRx force-pushed the gr/snap-blocklist-update branch from 36d11db to 6438c56 Compare August 2, 2023 09:28
@GuillaumeRx GuillaumeRx added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #20336 (6438c56) into develop (484fd1a) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20336   +/-   ##
========================================
  Coverage    68.69%   68.69%           
========================================
  Files          990      990           
  Lines        38082    38082           
  Branches     10200    10200           
========================================
  Hits         26159    26159           
  Misses       11923    11923           
Files Changed Coverage Δ
app/scripts/metamask-controller.js 65.52% <ø> (ø)

@metamaskbot
Copy link
Collaborator

Builds ready [6438c56]
Page Load Metrics (1474 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint102162125157
domContentLoaded1372163714738240
load1373163714748340
domInteractive1372163714738240
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx merged commit 36c0dfb into develop Aug 2, 2023
@GuillaumeRx GuillaumeRx deleted the gr/snap-blocklist-update branch August 2, 2023 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Aug 2, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants