Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v11 RC build issues #20540

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Fix v11 RC build issues #20540

merged 4 commits into from
Aug 21, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Aug 19, 2023

Explanation

Updates the yarn lock to fix checksums on v11 RC. The fix was created by reinstalling the dependencies on the RC branch using Yarn v3 instead of Yarn v4.

Also updates some E2E snapshots and fixes changelog linting to make CI pass.

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 19, 2023 22:00
@FrederikBolding FrederikBolding changed the title Fix snaps checksums on RC Fix v11 RC build issues Aug 21, 2023
@FrederikBolding FrederikBolding merged commit f104fac into Version-v11.0.0 Aug 21, 2023
@FrederikBolding FrederikBolding deleted the fb/fix-rc-yarn-lock branch August 21, 2023 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [0d80371]
Page Load Metrics (1803 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint108183141178
domContentLoaded16242100180313364
load16242100180313364
domInteractive16242100180313364

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants