Script to update the GitHub preview branches #6758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic usage: scripts/update-code-style-preview-branches.sh development mbedtls-2.28 Signed-off-by: Gilles Peskine <[email protected]>
This was referenced Dec 9, 2022
I had forgotten to rename the support function in all.sh. Thanks to David Horstmann. Signed-off-by: Gilles Peskine <[email protected]>
This way we can update it globally by force-pushing the tag. Signed-off-by: Gilles Peskine <[email protected]>
A force push to a remove identified by its URL doesn't actually work: Git complains about a stale reference. Use a remote name. Add an option to use different remote names for fetching and pushing, overriding autodetection. This is needed in nonstandard Git remote setups such as mine, where I have a separate remote name for pushing only to avoid accidentally pushing to the "normal" remote name. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
This was referenced Dec 19, 2022
gilles-peskine-arm
requested review from
AndrzejKurek and
mpg
and removed request for
mpg and
AndrzejKurek
This was referenced Jan 4, 2023
|
The new code style has been merged, so this script is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not intended to be merged, I'm just putting it out for visibility and to open comments.
The goal of this pull request is to share the script
scripts/update-code-style-preview-branches.sh, which we can use to keep preview branches up to date for the new code style. We'll be doing this on an informal schedule until the switch to the new code style, which we intend to make in the first week of January 2023.Basic usage:
Script quality: it's worked for me once. Caveat utor. I think it should work for others but I suggest first running
sh -x scripts/update-code-style-preview-branches.shwhich will fetch the resources it needs but not do anything destructive.The script relies on a commit which is located in a branch on the main repository, with the tag
features/new-code-style/switch-to-enforcement. Past versions of that commit are in https://github.com/gilles-peskine-arm/mbedtls/tree/coding-style-switch-to-enforcement-1 etc.This makes two branches available on the main Mbed TLS repository:
features/new-code-style/developmentfeatures/new-code-style/mbedtls-2.28