Backport 2.28: Don't restyle some PSA macros #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some preprocessor macro definitions must have a specific expansion so that the same macro name can be defined in different products. The definition of having the same expansion (per the C language specification) means the same sequence of tokens, and also the same absence/presence of spacing between tokens. For PSA error code definitions, the specific expansion is mandated by the PSA Status code specification and the PSA Crypto API specification. In particular, there must not be a space between (psa_status_t) and the numerical value (whereas K&R would put a space). Signed-off-by: Gilles Peskine <[email protected]>
Some preprocessor macro definitions must have a specific expansion so that the same macro name can be defined in different products. The definition of having the same expansion (per the C language specification) means the same sequence of tokens, and also the same absence/presence of spacing between tokens. Two macros are also defined in headers in the PSA Compliance test suite, so the test suite would fail to build if we changed the definitions. Preserve those definitions. Technically this is a bug in the test suite, since having extra spaces (or even a completely different constant expression with the same value) would still be compliant. Bug reported as ARM-software/psa-arch-tests#337 Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
3 tasks
davidhorstmann-arm
approved these changes
Jan 10, 2023
davidhorstmann-arm
added
single-reviewer
|
Marked as single reviewer since this is a trivial backport that only changes comments. |
davidhorstmann-arm
added
the
approved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial backport of #6878
Gatekeeper checklist
all.sh test_psa_compliancepassing on the preview branch once it's updated; check manually by runningscripts/code_style.py && tests/scripts/all.sh test_psa_compliance)