Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coding style change: run on CI #6354

Closed
gilles-peskine-arm opened this issue Sep 26, 2022 · 2 comments
Closed

Coding style change: run on CI #6354

gilles-peskine-arm opened this issue Sep 26, 2022 · 2 comments
Assignees
@davidhorstmann-arm
Labels
component-test Test framework and CI scripts enhancement size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Sep 26, 2022 •
edited
Loading

Run the coding style change script as a component in all.sh. This should generate a diff in a file, but not complain if the diff is non-empty.

The plan is to have it run for a while before we pull the switch and make a non-empty diff a failure.

No backport at this stage.
@gilles-peskine-arm gilles-peskine-arm added enhancement size-s Estimated task size: small (~2d) component-test Test framework and CI scripts labels Sep 26, 2022
This was referenced Sep 26, 2022
Closed
Closed
@gilles-peskine-arm
Copy link
Contributor Author

We should also check that the result is sane. At least let's run make test in the default config.

@gilles-peskine-arm
Copy link
Contributor Author

Fulfilled by #6705.

We did backport after all (#6706) because it's convenient to have this for setting up preview branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhorstmann-arm davidhorstmann-arm

Labels
component-test Test framework and CI scripts enhancement size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gilles-peskine-arm @davidhorstmann-arm