Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style change: pull the switch #6359

Closed
gilles-peskine-arm opened this issue Sep 26, 2022 · 1 comment · Fixed by #6907
Closed

Coding style change: pull the switch #6359

gilles-peskine-arm opened this issue Sep 26, 2022 · 1 comment · Fixed by #6907
Labels
component-test Test framework and CI scripts enhancement size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Sep 26, 2022

The goal of this task is to change to the new coding style. This means:

  • Change the all.sh component so that deviations are now failures.
  • Apply the reformatting to development and mbedtls-2.28.

Preview branches with the new code style are available:

The preview branches are updated from time to time. This is manually triggered but done using an automatic script. “Pulling the switch” means that these preview branches will become the new official branches (via pull requests).

Once the switch has been pulled, all work in progress will need to be restyled (otherwise almost anything that touches C code will have merge conflicts). We will provide a script to rewrite branches commit by commit.

For open pull requests that are undergoing review, synchronize with the reviewers to decide when to do the rewriting.

We will pull the switch in early January 2023.

@davidhorstmann-arm
Copy link
Contributor

Switched in #6907, #6908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Test framework and CI scripts enhancement size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants