-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changesets' auto-commit feature to not suppress CI on commits #1100
Conversation
🦋 Changeset detectedLatest commit: af68af2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 97 97
Lines 1392 1392
Branches 351 359 +8
=======================================
Hits 1390 1390
Misses 1 1
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
@jeremywiebe hmm any idea why the checks failed here? @somewhatabstract surely has thoughts on this. |
…2052) ## Summary: I recently updated our Changesets config to auto-commit the `.md` file when using `yarn changset` to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds `[skip ci]` to the commit created when running `yarn changesets version`. No CI on that PR/commit, meant that none of our release Github Actions ran! So this PR fixes the config so that Changesets no longer adds `[skip ci]` to any commits, but still auto-commits them. ### Similar PRs * Wonder-Blocks: Khan/wonder-blocks#2409 * Wonder-Stuff: Khan/wonder-stuff#1100 * Perseus: #2052 (this PR!) Issue: "none" ## Test plan: Land this PR Merge `main` into an open Version Packages PR Land that PR and ensure the release goes out Author: jeremywiebe Reviewers: catandthemachines, jandrade, somewhatabstract Required Reviewers: Approved By: catandthemachines, jandrade Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ⏹️ [cancelled] Publish npm snapshot (ubuntu-latest, 20.x), ⏹️ [cancelled] Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ⏹️ [cancelled] Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏹️ [cancelled] Cypress (ubuntu-latest, 20.x), ⏹️ [cancelled] Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x) Pull Request URL: #2052
It's because the check for what needs a changeset is a bit aggressive. It thinks that the change to
|
Size Change: 0 B Total Size: 4.63 kB ℹ️ View Unchanged
|
Summary:
I recently updated our Changesets config to auto-commit the
.md
file when usingyarn changset
to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds[skip ci]
to the commit created when runningyarn changesets version
. No CI on that PR/commit, meant that none of our release Github Actions ran!So this PR fixes the config so that Changesets no longer adds
[skip ci]
to any commits, but still auto-commits them.Similar PRs
Issue: "none"
Test plan:
Land this PR
Merge
main
into an open Version Packages PRLand that PR and ensure the release goes out