Skip to content

Commit

Permalink
Update changesets' auto-commit feature to not suppress CI on commits (#…
Browse files Browse the repository at this point in the history
…1100)

## Summary:

I recently updated our Changesets config to auto-commit the `.md` file when using `yarn changset` to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds `[skip ci]` to the commit created when running `yarn changesets version`. No CI on that PR/commit, meant that none of our release Github Actions ran!

So this PR fixes the config so that Changesets no longer adds `[skip ci]` to any commits, but still auto-commits them. 

### Similar PRs

  * Wonder-Blocks: Khan/wonder-blocks#2409
  * Wonder-Stuff: #1100 (this PR!)
  * Perseus: Khan/perseus#2052

Issue: "none"

## Test plan:

Land this PR
Merge `main` into an open Version Packages PR
Land that PR and ensure the release goes out

Author: jeremywiebe

Reviewers: jandrade, somewhatabstract

Required Reviewers:

Approved By: jandrade

Checks: ✅ Test (macos-latest, 20.x), ✅ codecov/project, ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Analyze (javascript), ✅ gerald, ⏭️  dependabot

Pull Request URL: #1100
  • Loading branch information
jeremywiebe authored Dec 20, 2024
1 parent 506ed87 commit 5a5f294
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .changeset/config.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://unpkg.com/@changesets/config@1.7.0/schema.json",
"$schema": "https://unpkg.com/@changesets/config@2/schema.json",
"changelog": "@changesets/cli/changelog",
"commit": true,
"commit": ["@changesets/cli/commit", { "skipCI": false }],
"linked": [],
"access": "public",
"baseBranch": "main",
Expand Down
2 changes: 2 additions & 0 deletions .changeset/short-buttons-juggle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---

0 comments on commit 5a5f294

Please sign in to comment.