Update changesets' auto-commit feature to not suppress CI on commits #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: NOT Published🤕 Oh noes!! We couldn't find any changesets in this PR (74efc15). As a result, we did not publish an npm snapshot for you. |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-vxpvzeyowb.chromatic.com/ Chromatic results:
|
|
Size Change: 0 B Total Size: 96.3 kB ℹ️ View Unchanged
|
jandrade
approved these changes
Dec 20, 2024
jandrade
added a commit
that referenced
this pull request
Dec 20, 2024
## Summary: This PR is meant to bump the version of the form package to test changesets. We are seeing if a change being applied in #2409 will fix the issue we are seeing with changesets not being triggering PR checks at all. This is causing that packages are not being published to NPM. Issue: XXX-XXXX ## Test plan: Land this PR and see if the changesets checks are triggered once the Release PR is created. Author: jandrade Reviewers: beaesguerra, jeremywiebe Required Reviewers: Approved By: beaesguerra Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏭️ dependabot Pull Request URL: #2410
jeremywiebe
added a commit
to Khan/perseus
that referenced
this pull request
Dec 20, 2024
…2052) ## Summary: I recently updated our Changesets config to auto-commit the `.md` file when using `yarn changset` to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds `[skip ci]` to the commit created when running `yarn changesets version`. No CI on that PR/commit, meant that none of our release Github Actions ran! So this PR fixes the config so that Changesets no longer adds `[skip ci]` to any commits, but still auto-commits them. ### Similar PRs * Wonder-Blocks: Khan/wonder-blocks#2409 * Wonder-Stuff: Khan/wonder-stuff#1100 * Perseus: #2052 (this PR!) Issue: "none" ## Test plan: Land this PR Merge `main` into an open Version Packages PR Land that PR and ensure the release goes out Author: jeremywiebe Reviewers: catandthemachines, jandrade, somewhatabstract Required Reviewers: Approved By: catandthemachines, jandrade Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ⏹️ [cancelled] Publish npm snapshot (ubuntu-latest, 20.x), ⏹️ [cancelled] Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ⏹️ [cancelled] Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏹️ [cancelled] Cypress (ubuntu-latest, 20.x), ⏹️ [cancelled] Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x) Pull Request URL: #2052
jeremywiebe
added a commit
to Khan/wonder-stuff
that referenced
this pull request
Dec 20, 2024
…1100) ## Summary: I recently updated our Changesets config to auto-commit the `.md` file when using `yarn changset` to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds `[skip ci]` to the commit created when running `yarn changesets version`. No CI on that PR/commit, meant that none of our release Github Actions ran! So this PR fixes the config so that Changesets no longer adds `[skip ci]` to any commits, but still auto-commits them. ### Similar PRs * Wonder-Blocks: Khan/wonder-blocks#2409 * Wonder-Stuff: #1100 (this PR!) * Perseus: Khan/perseus#2052 Issue: "none" ## Test plan: Land this PR Merge `main` into an open Version Packages PR Land that PR and ensure the release goes out Author: jeremywiebe Reviewers: jandrade, somewhatabstract Required Reviewers: Approved By: jandrade Checks: ✅ Test (macos-latest, 20.x), ✅ codecov/project, ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Analyze (javascript), ✅ gerald, ⏭️ dependabot Pull Request URL: #1100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I recently updated our Changesets config to auto-commit the
.mdfile when usingyarn changsetto describe a set of changes. This broke our releases as the default behaviour is that Changesets adds[skip ci]to the commit created when runningyarn changesets version. No CI on that PR/commit, meant that none of our release Github Actions ran!So this PR fixes the config so that Changesets no longer adds
[skip ci]to any commits, but still auto-commits them.Similar PRs
Issue: "none"
Test plan:
Land this PR
Merge
maininto an open Version Packages PRLand that PR and ensure the release goes out