Skip to content

Commit

Permalink
Update changesets' auto-commit feature to not suppress CI on commits (#…
Browse files Browse the repository at this point in the history
…2052)

## Summary:

I recently updated our Changesets config to auto-commit the `.md` file when using `yarn changset` to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds `[skip ci]` to the commit created when running `yarn changesets version`. No CI on that PR/commit, meant that none of our release Github Actions ran!

So this PR fixes the config so that Changesets no longer adds `[skip ci]` to any commits, but still auto-commits them. 

### Similar PRs

  * Wonder-Blocks: Khan/wonder-blocks#2409
  * Wonder-Stuff: Khan/wonder-stuff#1100
  * Perseus: #2052 (this PR!)

Issue: "none"

## Test plan:

Land this PR
Merge `main` into an open Version Packages PR
Land that PR and ensure the release goes out

Author: jeremywiebe

Reviewers: catandthemachines, jandrade, somewhatabstract

Required Reviewers:

Approved By: catandthemachines, jandrade

Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ⏹️  [cancelled] Publish npm snapshot (ubuntu-latest, 20.x), ⏹️  [cancelled] Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ⏹️  [cancelled] Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏹️  [cancelled] Cypress (ubuntu-latest, 20.x), ⏹️  [cancelled] Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x)

Pull Request URL: #2052
  • Loading branch information
jeremywiebe authored Dec 20, 2024
1 parent b138f0f commit 00ec1f1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .changeset/config.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://unpkg.com/@changesets/config@1.7.0/schema.json",
"$schema": "https://unpkg.com/@changesets/config@2/schema.json",
"changelog": ["@changesets/changelog-github", {"repo": "Khan/perseus"}],
"commit": true,
"commit": ["@changesets/cli/commit", { "skipCI": false }],
"linked": [],
"access": "public",
"baseBranch": "main",
Expand Down

0 comments on commit 00ec1f1

Please sign in to comment.