Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add duplicate support for multi select #3786

Closed
wants to merge 1 commit into from

Conversation

kimyu92
Copy link

@kimyu92 kimyu92 commented Sep 30, 2019

Updated: leaving here in case anyone find it useful: https://www.npmjs.com/package/react-select-plus-duplicate

@kimyu92
Copy link
Author

kimyu92 commented Sep 30, 2019

@JedWatson @gwyneplaine It is highly appreciated if you can review this PR in order to support duplicate feature for multi select against v1.x branch. Please feel free to reach out to me if you have any question. Thank you.

@JedWatson JedWatson added the v1 label Oct 2, 2019
@switz
Copy link

switz commented Oct 2, 2019

Wow, this is what I just so happen to be looking for, though mostly in regards to a Creatable. I presume they're quite intertwined. I was hoping I could just pass isValidNewOption={() => true} but it seems to override on duplicate values unfortunately. Perhaps this PR would enable that to work.

Happy to help push this through in any way if I can offer support/code.

@kimyu92
Copy link
Author

kimyu92 commented Oct 2, 2019

Wow, this is what I just so happen to be looking for, though mostly in regards to a Creatable. I presume they're quite intertwined. I was hoping I could just pass isValidNewOption={() => true} but it seems to override on duplicate values unfortunately. Perhaps this PR would enable that to work.

Happy to help push this through in any way if I can offer support/code.

🤞

@JedWatson btw, any idea on how to move forward with this PR?

@Cadrach
Copy link

Cadrach commented Nov 25, 2019

Any updates on this?

@flexdinesh
Copy link
Collaborator

flexdinesh commented Mar 22, 2020

Hey @kimyu92 v1 of react-select is no longer maintained.

We recommend maintaining your own v1 fork if you want to address v1 issues. We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our limited efforts to maintain the latest versions.

We highly recommend upgrading from v1 to v2.

I'm closing this issue now. Feel free add your thoughts in #3981 and reference this issue/PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants