passing labelKey and valueKey into optionRenderer and valueRenderer #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jossmac
requested changes
Jul 4, 2018
| @@ -568,7 +568,7 @@ class Select extends React.Component { | |||
| } | |||
|
|
|||
| getOptionLabel (op) { | |||
| return op[this.props.labelKey]; | |||
| return op.option[this.props.labelKey]; | |||
There was a problem hiding this comment.
Is this (op.option) intended?
|
Hey @jiangweiliu-aa v1 of react-select is no longer maintained. Thanks for taking your time out to create this PR but since this PR has changes for We highly recommend upgrading from v1 to v2. Chances are this issue might already be fixed or non-existent in v2. I'm closing this issue/PR now. Feel free add your thoughts in #3981 and reference this issue/PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Make
valueRendererandoptionRendereraccesslabelKeyandvalueKey.