Cache doesn't clear when props update

[veltman]

I've noticed that the default caching behavior for Select.Async is to create a cache object in the constructor, and then mutate that one object forever:

https://github.com/JedWatson/react-select/blob/master/src/Async.js#L56

This means that the cache doesn't clear when the props update, even if the props are changing everything about the input. Here's a simplified reproduction:

https://codepen.io/anon/pen/JpZzzY

1. The Select autoloads the list of turtles and caches it.
2. Click on "superheroes", which will update the Select with new props, including a different loadOptions function which should provide a list of superheroes.
3. Click on the input. You'll see a list of turtles.

I thought the workaround for this would be to include a newly-created cache object as a prop:

<Select.Async cache={{}} loadOptions={fn} ... />

So that whenever the component was re-rendered with new props, it would get a fresh cache object, and if I wanted something persistent I could pass that instead. But this doesn't work, because componentWillReceiveProps doesn't update the internal cache object, it's set forever in the constructor:

https://github.com/JedWatson/react-select/blob/master/src/Async.js#L75-L81

Is the current behavior intentional for some other benefit? If not, it seems like the desired behavior should be to always update the cache in componentWillReceiveProps, along the lines of:

componentWillReceiveProps(nextProps) {
  if (nextProps.cache !== this.props.cache) {
    this._cache = nextProps.cache === defaultCache ? {} : nextProps.cache;
  }
}

Then, if a user uses the default caching behavior, it will have the current behavior, but they at least have the ability to ensure that a cache object they specify as a prop actually becomes the cache on updates and not just during the first construction.

If this makes sense to you I can work up a PR.

[jossmac]

Possibly related #2661, #2582

[flexdinesh]

Hey @veltman this issue is resolved in v2. v1 of react-select is no longer maintained.

We recommend maintaining your own v1 fork if you want to address v1 issues. We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our limited efforts to maintain the latest versions.

We highly recommend upgrading from v1 to v2.

I'm closing this issue/PR now. Feel free add your thoughts in #3981 and reference this issue/PR if needed.