Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character item focus #2457

Closed
wants to merge 2 commits into from
Closed

Conversation

johnnytomcat
Copy link

When in a non searchable field, tap a key and focus to that item. Ex: US States -Tapping 'T' would focus to Texas, tapping it again for focus Tennessee.

@jossmac jossmac added v1 labels Jul 4, 2018
@gwyneplaine gwyneplaine added feature and removed v1 labels Jul 4, 2018
@gwyneplaine
Copy link
Collaborator

@johnnytomcat, thanks for the PR, however I think we should examine this as a future feature of react-select v2, as this is difficult to do in v1 without compromising existing functionality. @JedWatson would like to get your thoughts on this.

@JedWatson JedWatson added v1 and removed v2 labels Jul 23, 2018
@flexdinesh
Copy link
Collaborator

Hey @johnnytomcat v1 of react-select is no longer maintained.

Thanks for taking your time out to create this PR but since this PR has changes for v1, we cannot merge it right away. If you would like to discuss this feature for the latest versions of react-select, please open an issue with feature details and we could move forward with the discussion there. We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our limited efforts to maintain the latest versions.

We highly recommend upgrading from v1 to v2.

I'm closing this issue/PR now. Feel free add your thoughts in #3981 and reference this issue/PR if needed.

@flexdinesh flexdinesh closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants