Small improvements to the Prepare > Check Data > Duplicates dialog #7354
Conversation
…/master updated my master
There was a problem hiding this comment.
I really did think this was only a small task:
I am keen that the option titled Index Number of Duplicates should have Index as the default. It still has Count.
I changed it to Index and it works fine. Then the screen shot show what happens when I return. It has changed back to Count. It is supposed to remember the previous setting.
I notice you have changed Index to be the first of the 2 options, where it was Count before. That's fine, but it isn't sufficient.
|
Hello @rdstern i have done all these changes on the PR, but they do not show because of the database Translation, that is why we will make a PR for the database translation to correct this PR |
…/master updating my master
|
@lloyddewit @rdstern, @derekagorhom and I have created PR #7363 that contains the required translation changes. Once merged this will be ready for review. |
|
@derekagorhom you may want to create a new issue about how the designer class name of the |
There was a problem hiding this comment.
@derekagorhom and @Patowhiz I don't understand why this change is causing so many problems.
In this option Count is still given as the default (Though Index is the first of the two options.
And if I change to Index, then it does it fine. But when I return to the dialogue it still has returned to count.
If this continues, perhaps instead we should have a 4th option for the radio button. But I really don't know why Index couldn't be the default, and why it can't remember the setting. That's what we usually do?
|
@rdstern you may have to wait for the translation PR #7363 to be merged. @lloyddewit is aware of that too. |
New derick translations
|
@rdstern I made a small change that should not affect the functionality. If you test/approve again, then we can merge. |
lloyddewit
changed the title
Fixes #7299
Small changes in the duplicates Dialogue
Selected Variables has become the first button, and hence the default when you first use the dialogue. The Data Frame is then second. The Successive values remains the last button.
And the pull down has the first entry as Index.
@Patowhiz and I will make a new PR for the database changes recommended by @lloyddewit in #7305