Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes in the Prepare > Check Data > Duplicates dialogue #7299

Closed
rdstern opened this issue Mar 13, 2022 · 1 comment · Fixed by #7354
Closed

Small changes in the Prepare > Check Data > Duplicates dialogue #7299

rdstern opened this issue Mar 13, 2022 · 1 comment · Fixed by #7354
Assignees
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Mar 13, 2022

  1. Could the name of the dialogue be Duplicate Rows. That is at the top of the dialogue and hopefully also the Menu item (unless that should wait for other changes to the menus - see Changes in menu items #7297 .
  2. The most used option is the second, namely Selected Variables. So could that become the first button, and hence the default when you first use the dialogue. The Data Frame is then second. The Successive values remains the last button.
  3. In the 3rd radio button below the selector, the label i Index Number of Duplicates. Then the pull down has the first entry as Count. Please swap them, so the first entry is Index.
  4. Currently this control doesn't "remember" the setting when you return to the dialogue. Could it please remember.

@shadrackkibet who can do these. It should only taker a few minutes?

@derekagorhom
Copy link
Contributor

@rdstern we looked into this issue with @Patowhiz and we also realized that the dialog is producing duplicate R commands. I wonder if this was intentional.

What the dialog produces;

# Code generated by the dialog, Duplicate Rows

dup <- duplicated_count_index(x=data_book$get_columns_from_data(data_name="date_example", col_names="week", use_current_filter=FALSE), type="index")
data_book$add_columns_to_data(data_name="date_example", col_name="dup", col_data=dup, before=FALSE, adjacent_column="week")

dup <- data_book$get_columns_from_data(data_name="date_example", col_names="dup")
data_book$add_columns_to_data(data_name="date_example", col_name="dup", col_data=dup, before=FALSE, adjacent_column="week")
summary(object=data_book$get_columns_from_data(data_name="date_example", col_names="dup"))
rm(list=c("dup", "dup"))

What we think it should be producing;

# Code generated by the dialog, Duplicate Rows

dup1 <- duplicated_count_index(x=data_book$get_columns_from_data(data_name="date_example", col_names="week", use_current_filter=FALSE), type="index")
data_book$add_columns_to_data(data_name="date_example", col_name="dup1", col_data=dup1, before=FALSE, adjacent_column="week")
summary(object=data_book$get_columns_from_data(data_name="date_example", col_names="dup1"))
rm(list=c("dup1", "dup1"))

If the current duplicated R commands is not correct, should we correct it in PR #7305 or in a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants