Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate rows translations changes #7363

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Duplicate rows translations changes #7363

merged 3 commits into from
Apr 20, 2022

Conversation

Patowhiz
Copy link
Contributor

@Patowhiz Patowhiz commented Apr 7, 2022

This PR contains translations changes needed for the duplicate rows dialog.
Related to issue #7299 and PR #7354.

@africanmathsinitiative/developers this is ready for review.

@Patowhiz Patowhiz mentioned this pull request Apr 7, 2022
Merged
lloyddewit
lloyddewit approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Patowhiz This is a binary file so there's no diff.
I approved but I assume that, before @rdstern approves, he will want to know which text you changed.
Please could you list the database changes that you made? thanks

@Patowhiz
Copy link
Contributor Author

Patowhiz commented Apr 9, 2022

@rdstern @lloyddewit
The translations chnaged are, the dialog title and I also set the database to not translate the dropdown menu mentioned in the issue.
We tested this with @derekagorhom .

@derekagorhom
Copy link
Contributor

@rdstern could you approve this PR so that we can finalize the changes on PR #7354

@lloyddewit lloyddewit added the skip-releasenotes PRs that don't affect functionality and should not be included in the release notes label Apr 20, 2022
@lloyddewit lloyddewit merged commit 7a6129b into IDEMSInternational:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloyddewit lloyddewit lloyddewit approved these changes

@rdstern rdstern rdstern approved these changes

Assignees
No one assigned
Labels
skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Patowhiz @derekagorhom @rdstern @lloyddewit @conlooptechnologies