-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially Fixes Duplicates Dialogue #7305
Partially Fixes Duplicates Dialogue #7305
Conversation
…/master updated my master
@derekagorhom thank you for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have the change in order of the top buttons.
The top title and the menu item is still to change as is the order of count and index.
…/master updated my master
…nges_Duplicates_Dialogue Partially Fixes Duplicates Dialogue
Added required changes
…nges_Duplicates_Dialogue Small changes duplicates dialogue
Translation changes
Added translations DoNotTranslate
Hello @rdstern could you test this again? |
@derekagorhom almost. I am not clear why this task is so tricky. |
@shadrackkibet i have added a commit, could you check and confirm if the dialogue is working properly again |
@derekagorhom now you have conflicts in your PR. |
@shadrackkibet could you test it again |
What about this conflicting file? |
@Patowhiz could you have a look at this please |
@derekagorhom The database file is binary so we can't resolve the conflict within this PR. To resolve this conflict, you could do one of the following:
The first option may be easiest for this PR. |
@lloyddewit to avoid this it will be good to have someone doing that, I think as discussed with @Vitalis95 who is happy doing that, I suggest these changes to be done by @Vitalis95 in his PR #7324. |
@N-thony yes, that sounds sensible |
@lloyddewit it is Ok from my side. |
Hello Lloyd i tried what you ask me to do and now i can't push the changes to the PR. so i am thinking the earlier suggestion is ok with me; |
@lloyddewit and @N-thony would it be ok if i just closed this PR and make a new PR? |
@derekagorhom did you manage to resolve the translations conflicts, I know we made several changes to that file. Please feel free to contact me directly on the same. |
@derekagorhom yes, a new PR sounds sensible. Not sure what went wrong here, sorry for any confusion. |
Fixes (partially) issue #7299
Small changes in the duplicates Dialogue
Selected Variables has become the first button, and hence the default when you first use the dialogue. The Data Frame is then second. The Successive values remains the last button.
And the pull down has the first entry as Index.
@Ivanluv could you please test this to confirm