-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.8 migration #47274
Comments
- According to [its GitHub repo](https://github.com/rtomayko/shocco), this software is no longer maintained as of 2017. - It's had 4 installs over the past 90 days, and 19 over the past 365 days. - It third from the bottom of our [list of formulae that need building with Python 3.8](Homebrew#47274).
- According to [its GitHub repo](https://github.com/rtomayko/shocco), this software is no longer maintained as of 2017. - It's had 4 installs over the past 90 days, and 19 over the past 365 days. - It third from the bottom of our [list of formulae that need building with Python 3.8](#47274).
To help out follow How To Open a Homebrew Pull Request (and get it merged)?
One of the formulas above? Change
Test
Issue PR? |
WIP Homebrew#45337 Change dependency to python3
Hey @basictheprogram, Currently, we're working on adding I'll let you know when #47326 is merged and you could help us there. Thanks a lot! |
I would like to migrate a formula that has: py_exe = Utils.popen_read("which python3").strip
py_prefix = Utils.popen_read("python3 -c 'import sys;print(sys.prefix)'").chomp
py_inc = Utils.popen_read("python3 -c 'from distutils import sysconfig;print(sysconfig.get_python_inc(True))'").chomp
...
system "python3" ... I think these would need to be updated to pick up the correct python3.8? And would something like this help: Formula["[email protected]"].opt_libexec Edit: Here's what I would propose: py_exe = Formula["[email protected]"].opt_bin / "python3"
py_prefix = Utils.popen_read("#{py_exe} -c 'import sys;print(sys.prefix)'").chomp
py_inc = Utils.popen_read("#{py_exe} -c 'from distutils import sysconfig;print(sysconfig.get_python_inc(True))'").chomp
...
system py_exe ... Would that be right? Am I overthinking this, does it somehow have the correct path setup to pick up 3.8 by default? (I won't be able to migrate it yet, waiting on Numpy) |
If you're talking about If about another formula, then (generally) it's not required to do anything extra because for installation we use |
Thanks! Yes, primarily for ROOT. |
|
It was updated; but I probably lost track of some stuff. Here is the new list:
|
Output$ brew deps gtsgdbm gettext glib jasper jpeg libffi libpng libtiff netpbm [email protected] pcre **python** readline sqlite xz |
|
Strange. Forced reinstallation of gts solved this, thanks! |
Thanks for the hard work here. Some feedback from a user who lost more time than he likes because this work was hidden to me. My vimrc stopped loading correctly because powerline-status was not found by the python used by vim. I had triple checked that I had not corrupted something in the setup before checking something was not wrong with python3 in vim. This is when I discovered that it was a different version than what installed by the python formula. |
Sorry if we broke some stuff along the way. There was no specific warning about this. It's quite hard for us to make sure everything survives an update, especially plugins and internal stuff which is not installed by us. We can provide support on a best effort for these cases, but rely mostly on pull requests to improve these kind of migrations. |
Is it possible to add the "alt-install" style links, python3.8 and friends, to the [email protected] formula? Sort of an alt-install like link to Note: in this case, it looks like black has a brew formula. Though I do use this all the time: /usr/local/opt/[email protected]/bin/python3 -m venv .env |
Homebrew is migrating formulas to [email protected] Homebrew/homebrew-core#47274 Our homebrew dependencies have already migrated as well. Also, properly install the six python package.
@iMichka looks like all the formulae in homebrew that support Python 3.8 have been converted, leaving I suppose this draft is outdated - |
Salt was just migrated with their last release. |
Silently converting |
We just released a new version of brew with improvements to the upgrade process. Can you upgrade again and see if things get sorted out? |
I did a |
|
Brew always. |
It's possible it would have been fine if I went from the 3.7 to the newest version without reinstalling it after the initial 3.8 upgrade. I tried Jupyter lab and black just now, and those work. Also, pre-commit has a tendency to break on upgrades, IIRC - I'm pretty sure I've brew reinstalled it a few times. |
If you re-installed it between yesterday and today there might have been some issues. Especially if you re-installed with a from-source build. I could not reproduce the error on my side. If a uninstall/install fixed it for you, then we are all good. Migrations are tricky and we are trying to do our best. The python 3.7 to 3.8 was especially difficult for us this time. |
If you first upgraded prior to brew 2.4.5's release, run |
Closing here, migration is done. 27 Nov 2019 - 9 July 2020 |
Homebrew has a lot of formulae that depend on
python
and migration at one go ended up with lack of disk space on CI agents (#45337), so this time we're trying to do the migration in several PRs.The first one PR adds
[email protected]
(#47273)Here is the whole (long) list formulae with total stats for 90 days:
The text was updated successfully, but these errors were encountered: