-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtensorflow: add tools #47330
libtensorflow: add tools #47330
Conversation
66de392
to
7401b50
Compare
c915690
to
c251a94
Compare
On Catalina only:
|
c251a94
to
f7b15ca
Compare
This comment has been minimized.
This comment has been minimized.
Okay, it's a tar bug strikes again (Homebrew/brew#6539):
|
f7b15ca
to
4aa10d3
Compare
So, TensorFlow 2.1 has been released, all checks/tests have passed for Mojave and High Sierra, a test on Catalina fails due to Homebrew/brew#6539. Maintainer, please remove Catalina bottle before a push, thanks! |
4aa10d3
to
ff2f887
Compare
The Catalina bug doesn't usually manifest itself with segfaults. Are you in a position to investigate and get a stack trace of that segfault? |
Here it is for transform_graph (installed a bottle from bintray): https://gist.github.com/bayandin/3e3f3e11df65f262eced2770342350e4 Also, I've mentioned before about zeroes in benchmark_model (#47330 (comment)), so for the last rebuild I don't have it (could be related to building 2.1.0 instead of 2.1.0-rc2 or changing python to [email protected]) |
And want to mention that some |
|
Thanks, will do it a bit later! |
Extracted library update into separate PR to get that merged (#48957). And has changes this PR to just adding tool (+ Catalina problems investigation) |
ff2f887
to
e1ab5da
Compare
e1ab5da
to
db4e87b
Compare
As of today, the bottle corruption bug is fixed on our CI machines. @BrewTestBot test this please, to confirm whether that fixes the issue here or not |
It's green, yay 🎉 |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This PR upgrades version of TensorFlow to 2.1, adds graph/model tools (benchmark_model, summarize_graph, and transform_graph) and migrates this formula to [email protected] (#47274)