Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtensorflow: add tools #47330

Closed
wants to merge 1 commit into from

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Nov 29, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This PR upgrades version of TensorFlow to 2.1, adds graph/model tools (benchmark_model, summarize_graph, and transform_graph) and migrates this formula to [email protected] (#47274)

@bayandin bayandin force-pushed the libtensorflow-2.1.0 branch from 66de392 to 7401b50 Compare December 2, 2019 20:13
@bayandin bayandin force-pushed the libtensorflow-2.1.0 branch 3 times, most recently from c915690 to c251a94 Compare December 24, 2019 11:52
@fxcoudert
Copy link
Member

On Catalina only:

==> /usr/local/Cellar/libtensorflow/2.1.0-rc2/bin/transform_graph --in_graph=/private/tmp/libtensorflow-test-20191224-10860-13oxfub/graph.pb --out_graph=/private/tmp/libtensorflow-test-20191224-10860-13oxfub/graph-new.pb --inputs=n/a --outputs=n/a --transforms="obfuscate_names" 2>&1
sh: line 1: 10882 Segmentation fault: 11  /usr/local/Cellar/libtensorflow/2.1.0-rc2/bin/transform_graph --in_graph=/private/tmp/libtensorflow-test-20191224-10860-13oxfub/graph.pb --out_graph=/private/tmp/libtensorflow-test-20191224-10860-13oxfub/graph-new.pb --inputs=n/a --outputs=n/a --transforms="obfuscate_names" 2>&1

@bayandin bayandin force-pushed the libtensorflow-2.1.0 branch from c251a94 to f7b15ca Compare January 2, 2020 14:28
@bayandin

This comment has been minimized.

@bayandin
Copy link
Member Author

bayandin commented Jan 2, 2020

Okay, it's a tar bug strikes again (Homebrew/brew#6539):

$ xxd benchmark_model | head -10
00000000: 320a 300a 3430 3936 0a38 3338 3836 3038  2.0.4096.8388608
00000010: 0a32 3130 3830 3337 3136 0a00 0000 0000  .210803716......
00000020: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000030: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000040: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000050: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000060: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000070: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000080: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000090: 0000 0000 0000 0000 0000 0000 0000 0000  ................

@bayandin bayandin force-pushed the libtensorflow-2.1.0 branch from f7b15ca to 4aa10d3 Compare January 8, 2020 19:04
@bayandin bayandin marked this pull request as ready for review January 8, 2020 19:06
@bayandin
Copy link
Member Author

bayandin commented Jan 9, 2020

So, TensorFlow 2.1 has been released, all checks/tests have passed for Mojave and High Sierra, a test on Catalina fails due to Homebrew/brew#6539.

Maintainer, please remove Catalina bottle before a push, thanks!

@bayandin bayandin requested a review from fxcoudert January 9, 2020 13:03
@bayandin bayandin force-pushed the libtensorflow-2.1.0 branch from 4aa10d3 to ff2f887 Compare January 10, 2020 12:20
@fxcoudert
Copy link
Member

The Catalina bug doesn't usually manifest itself with segfaults. Are you in a position to investigate and get a stack trace of that segfault?

@bayandin
Copy link
Member Author

bayandin commented Jan 12, 2020

The Catalina bug doesn't usually manifest itself with segfaults. Are you in a position to investigate and get a stack trace of that segfault?

Here it is for transform_graph (installed a bottle from bintray): https://gist.github.com/bayandin/3e3f3e11df65f262eced2770342350e4

Also, I've mentioned before about zeroes in benchmark_model (#47330 (comment)), so for the last rebuild I don't have it (could be related to building 2.1.0 instead of 2.1.0-rc2 or changing python to [email protected])

@bayandin
Copy link
Member Author

And want to mention that some bazel scripts are crashing during the build (bazelbuild/bazel#10142). Probably it's not a reason for the current problem because it affects all macOS versions.

@fxcoudert
Copy link
Member

  • Yes, the bottle corruption is semi-random, so it can appear and disappear with seemingly minor changes.
  • That stack trace is not a bottle corruption, it looks like a real problem. Can you report it to tensorflow?

@bayandin
Copy link
Member Author

  • That stack trace is not a bottle corruption, it looks like a real problem. Can you report it to tensorflow?

Thanks, will do it a bit later!

@bayandin bayandin changed the title libtensorflow 2.1.0 libtensorflow: add tools Jan 13, 2020
@bayandin bayandin mentioned this pull request Jan 13, 2020
5 tasks
@bayandin
Copy link
Member Author

Extracted library update into separate PR to get that merged (#48957). And has changes this PR to just adding tool (+ Catalina problems investigation)

@bayandin bayandin force-pushed the libtensorflow-2.1.0 branch from ff2f887 to e1ab5da Compare January 14, 2020 23:06
@bayandin bayandin force-pushed the libtensorflow-2.1.0 branch from e1ab5da to db4e87b Compare January 14, 2020 23:11
@fxcoudert
Copy link
Member

As of today, the bottle corruption bug is fixed on our CI machines. @BrewTestBot test this please, to confirm whether that fixes the issue here or not

@bayandin
Copy link
Member Author

It's green, yay 🎉
Thanks for the help @fxcoudert!

@fxcoudert fxcoudert closed this in d23043a Jan 19, 2020
@bayandin bayandin deleted the libtensorflow-2.1.0 branch January 19, 2020 02:32
@lock lock bot added the outdated PR was locked due to age label Feb 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants