Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.8: migrate independent formulae #48323

Closed
wants to merge 62 commits into from

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Dec 27, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This PR migrates to [email protected] independent formulae which:

  • depends only on python
  • doesn't have any depending formulae
  • uses virtualenv_install_with_resources for installation

Ref: #47274

@bayandin bayandin changed the title python 3.8.0: migrate independent formulae python 3.8: migrate independent formulae Dec 27, 2019
@bayandin bayandin added the python Python use is a significant feature of the PR or issue label Dec 27, 2019
@bayandin bayandin force-pushed the python-3.8.0-p3 branch 2 times, most recently from edf12f2 to 67657b9 Compare December 27, 2019 23:29
@fxcoudert
Copy link
Member

brew-test-bot.mojave.test bumpversion
brew-test-bot.mojave.test peru
brew-test-bot.mojave.test pyinstaller
brew-test-bot.mojave.install --build-bottle snakemake
brew-test-bot.mojave.test stormpath-cli
brew-test-bot.mojave.install ./tox--3.14.1_1.mojave.bottle.tar.gz

@bayandin
Copy link
Member Author

bayandin commented Dec 28, 2019

  • bumpversion — can't reproduce locally, let's try again
  • peru — looks like it calls python3 interpreter directly; dropped from the PR for now
  • pyinstaller — added patch
  • snakemake — doesn't support Python 3.8 because of resource dependency datrie which doesn't support Python 3.8; dropped from the PR
  • stormpath-cli — deleted formula in stormpath-cli: delete #48350
  • tox — fixed postinstall and test

@fxcoudert
Copy link
Member

fxcoudert commented Dec 29, 2019

pyinstaller says:

ValueError: script '/usr/local/Cellar/pyinstaller/3.5_1/libexec/lib/python/site-packages/easy_install.py' not found

I recommend merging everything except bumpversion and pyinstaller, rather than rerun the whole thing again. Let me know if you're okay with that, and I can do it.

@fxcoudert fxcoudert added the ready to merge PR can be merged once CI is green label Dec 29, 2019
@bayandin
Copy link
Member Author

I recommend merging everything except bumpversion and pyinstaller, rather than rerun the whole thing again. Let me know if you're okay with that, and I can do it.

Sounds good to me, let's do it.
Thanks @fxcoudert!

@fxcoudert fxcoudert closed this in 3e57ddf Dec 29, 2019
@fxcoudert
Copy link
Member

It is done.

@fxcoudert
Copy link
Member

For reference: I merged everything with brew pull --bottle 48323, then rebased to remove the 4 unwanted commits (bumpversion, pyinstaller, and their two bottle commits), then logged into bintray to delete the bumpversion and pyinstaller bottles (so they won't be a problem later, when we actually bump revision on these formulas).

@bayandin bayandin deleted the python-3.8.0-p3 branch December 29, 2019 12:36
@lock lock bot added the outdated PR was locked due to age label Jan 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants