cgal 5.0

[maxGimeno]

This is a WIP PR to upgrade CGAL to the new version.
Just checking with the CI that everything is OK, waiting for the true Release to upgrade for real.

[fxcoudert]

Formulas that need a revision bump (one commit per formula): graph-tool sfcgal pgrouting

[maxGimeno]

After investigation, I found out that sfcgal was not compatible with c++11, but they are working on it see this PR for example.
On the other hand, graph-tools doesn't seem to be compatible wither with CGAL 5.0, I think their configure file explicitly looks for a .so , but we are now header only.

[fxcoudert]

CGAL is now header-only? No library?

[maxGimeno]

Exactly. It is still possible to build it, but it would be odd to provide the lib version on package managers when we document it as header-only, IMHO.

[fxcoudert]

What's the point of these cmake flags, then?

      -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON
      -DCMAKE_INSTALL_NAME_DIR=#{HOMEBREW_PREFIX}/lib

[maxGimeno]

None probably, I wasn't sure of their effect, so I left theim here but thought they probably became useless.

[maxGimeno]

The release 5.0 is now officially out, and I updated the PR.

[Bo98]

Thanks for this. We're currently building Python 3.8 (see #45337), which involves revision bumping almost all Python formulae, so we're going to wait on this until that's finished to avoid merge conflicts. I'll let you know when we're ready.

[fxcoudert]

@maxGimeno graph-tool is not rebuilding, because its revision was increased by another PR. Please rebase on top of master.

[SMillerDev]

Please don't use merge commits. It makes the CI go crazy.

[maxGimeno]

@SMillerDev O, sorry. I rebased on master.

[fxcoudert]

@maxGimeno in the process of rebasing, you lost the graph-tool revision bump.
While you redo, can you please make sure you have 1 commit per formula (file), with:

• cgal 5.0 as commit message for the main formula
• pgrouting: revision for cgal as commit message for the others

[fxcoudert]

@BrewTestBot test this please

[fxcoudert]

sfcgal fails to build:

  Could not find a configuration file for package "CGAL" that is compatible
  with requested version "4.3".

  The following configuration files were considered but not accepted:

    /usr/local/lib/cmake/CGAL/CGALConfig.cmake, version: unknown
    /usr/local/opt/cgal/lib/cmake/CGAL/CGALConfig.cmake, version: unknown

graph-tool fails to build:

configure: error: CGAL library not found

[maxGimeno]

Ok, I just found out that graph-tool does not work in core/master either, when it does not come from a bottle. The compilation fails with the following :

graph_cairo_draw.cc:1868:34: error: use of undeclared identifier 'CoroGenerator'
    return boost::python::object(CoroGenerator(dispatch));

I saw in #47274 that graph-tool is not yet migrated to python 3.8, it may be related.

[maxGimeno]

I did a patch and tried to install graph-tool from brew. Everything works but I'd like somebody from graph-tool to review my patch, to be sure.

[fxcoudert]

Have the two patches been reported upstream? Are they accepted?

[maxGimeno]

Sfcgal and pgrouting already have patches in their master branch, but I still need to report to graph-tool... And find a working fix for pgrouting.

[maxGimeno]

@fxcoudert This time it seems ready \o/

[lrineau]

@fxcoudert Hi FX.

Have the two patches been reported upstream? Are they accepted?

In the last version, Maxime has added a comment for each of the three patches.

• ✔️ SFCGAL and pgRouting are already fixed upstream (in their master branches, no new releases so far).
• ⛔ The issue has been reported to graph-tool, but the upstream developer wants to wait for the arrival of CGAL-5.0 in ArchLinux, and ArchLinux is waiting for a new release of OpenSCAD (fixed with CGAL-5.0 in its master branch, a release 2020.01 is planned).

Is that blocking the integration of this PR? This PR also fixes the build of pgRouting (broken in the master of homebre-core) independently of CGAL-5.0.

[chenrui333]

@BrewTestBot test this please

[chenrui333]

Thanks @maxGimeno @lrineau!!