Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding Pub/Sub retryableCodes in pull settings #670

Closed
elefeint opened this issue Oct 25, 2021 · 0 comments · Fixed by #677
Closed

Allow overriding Pub/Sub retryableCodes in pull settings #670

elefeint opened this issue Oct 25, 2021 · 0 comments · Fixed by #677
Assignees
@elefeint
Labels
priority: p0 pubsub type: enhancement New feature or request

Comments

@elefeint
Copy link
Contributor

Pub/Sub client library by default retries UNKNOWN, ABORTED and UNAVAILABLE gRPC codes. For certain usecases, also retrying INTERNAL code is useful.

When creating subscriber stub, we should allow property-based overriding of retryable gRPC codes. Client library defaults should apply if custom codes are not provided.

Example of setting retryiable codes through the client library:

 RetrySettings retrySettings = RetrySettings.newBuilder()
        .setMaxAttempts(maxRetryAttempts)
        .setTotalTimeout(Duration.ofMinutes(10))
        .build();
    settingsBuilder.pullSettings().setRetrySettings(retrySettings).setRetryableCodes(StatusCode.Code.INTERNAL);
    SubscriberStubSettings settings = settingsBuilder.build();
@elefeint elefeint self-assigned this Oct 25, 2021
meltsufin added a commit that referenced this issue Oct 25, 2021
@meltsufin
Allow overriding Pub/Sub retryableCodes in pull settings
1bc02e5 
Fixes: #670.
@meltsufin meltsufin mentioned this issue Oct 25, 2021
Merged
meltsufin added a commit that referenced this issue Oct 25, 2021
@meltsufin
Allow overriding Pub/Sub retryableCodes in pull settings (#672)
8753532 
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
meltsufin added a commit that referenced this issue Oct 25, 2021
@meltsufin
Allow overriding Pub/Sub retryableCodes in pull settings (#672)
1f681ac 
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
meltsufin added a commit that referenced this issue Oct 25, 2021
@meltsufin
Allow overriding Pub/Sub retryableCodes in pull settings (#672)
81e050d 
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
mpeddada1 pushed a commit that referenced this issue Oct 26, 2021
@meltsufin @mpeddada1
Allow overriding Pub/Sub retryableCodes in pull settings (#672)
160e9e9 
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
@elefeint elefeint mentioned this issue Oct 26, 2021
Merged
mpeddada1 added a commit that referenced this issue Oct 28, 2021
@mpeddada1
Forward porting changes from 2.0.4.patch branch (#677)
e6b80e5 
Allow overriding Pub/Sub retryableCodes in pull settings (#672)

Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670
@mpeddada1 mpeddada1 mentioned this issue Nov 16, 2021
Merged
mpeddada1 added a commit that referenced this issue Nov 18, 2021
@mpeddada1
Add subscription-specific settings for retryableCodes (#706)
43ad8d8 
Support subscription-specific settings for retryable codes.

We recently introduced support for overriding retryableCodes in pull settings (#670). However, this property can only be set globally. This PR enables subscription-specific configuration.The retryableCodes configuration can be set in the following manner:
Global
`spring.cloud.gcp.pubsub.subscriber.retryableCodes=INTERNAL, ABORTED`
Subscription-specific
`spring.cloud.gcp.pubsub.subscription.mySubscription.retryableCodes=INTERNAL, ABORTED`
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this issue Oct 20, 2022
@kateryna216
Forward porting changes from 2.0.4.patch branch (GoogleCloudPlatform#677
7fd6cf4 
)

Allow overriding Pub/Sub retryableCodes in pull settings (GoogleCloudPlatform#672)

Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: GoogleCloudPlatform#670
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this issue Oct 20, 2022
@kateryna216
Add subscription-specific settings for retryableCodes (GoogleCloudPla…
d8723ef 
…tform#706)

Support subscription-specific settings for retryable codes.

We recently introduced support for overriding retryableCodes in pull settings (GoogleCloudPlatform#670). However, this property can only be set globally. This PR enables subscription-specific configuration.The retryableCodes configuration can be set in the following manner:
Global
`spring.cloud.gcp.pubsub.subscriber.retryableCodes=INTERNAL, ABORTED`
Subscription-specific
`spring.cloud.gcp.pubsub.subscription.mySubscription.retryableCodes=INTERNAL, ABORTED`
@elefeint elefeint added the type: enhancement New feature or request label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elefeint elefeint

Labels
priority: p0 pubsub type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forward porting changes from 2.0.4.patch branch GoogleCloudPlatform/spring-cloud-gcp
1 participant
@elefeint