Add subscription-specific settings for retryableCodes #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeddada1
changed the title
elefeint
suggested changes
Nov 18, 2021
...cp-pubsub/src/main/java/com/google/cloud/spring/pubsub/support/DefaultSubscriberFactory.java
Show resolved
Hide resolved
elefeint
approved these changes
Nov 18, 2021
.../test/java/com/google/cloud/spring/autoconfigure/pubsub/GcpPubSubAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
.../test/java/com/google/cloud/spring/autoconfigure/pubsub/GcpPubSubAutoConfigurationTests.java
Show resolved
Hide resolved
...cp-pubsub/src/main/java/com/google/cloud/spring/pubsub/support/DefaultSubscriberFactory.java
Show resolved
Hide resolved
elefeint
approved these changes
Nov 18, 2021
|
Kudos, SonarCloud Quality Gate passed! |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
…tform#706) Support subscription-specific settings for retryable codes. We recently introduced support for overriding retryableCodes in pull settings (GoogleCloudPlatform#670). However, this property can only be set globally. This PR enables subscription-specific configuration.The retryableCodes configuration can be set in the following manner: Global `spring.cloud.gcp.pubsub.subscriber.retryableCodes=INTERNAL, ABORTED` Subscription-specific `spring.cloud.gcp.pubsub.subscription.mySubscription.retryableCodes=INTERNAL, ABORTED`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #418
We recently introduced support for overriding retryableCodes in pull settings (#670). However, this property can only be set globally. This PR enables subscription-specific configuration.
The
retryableCodesconfiguration can be set in the following manner:Global
Subscription-specific