-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding Pub/Sub retryableCodes in pull settings #670
Labels
Comments
meltsufin
added a commit
that referenced
this issue
Oct 25, 2021
meltsufin
added a commit
that referenced
this issue
Oct 25, 2021
Introduces a new configuration property to customize subscriber pull retryable codes. Example: ``` spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL ``` Fixes: #670.
meltsufin
added a commit
that referenced
this issue
Oct 25, 2021
Introduces a new configuration property to customize subscriber pull retryable codes. Example: ``` spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL ``` Fixes: #670.
meltsufin
added a commit
that referenced
this issue
Oct 25, 2021
Introduces a new configuration property to customize subscriber pull retryable codes. Example: ``` spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL ``` Fixes: #670.
mpeddada1
pushed a commit
that referenced
this issue
Oct 26, 2021
Introduces a new configuration property to customize subscriber pull retryable codes. Example: ``` spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL ``` Fixes: #670.
mpeddada1
added a commit
that referenced
this issue
Nov 18, 2021
Support subscription-specific settings for retryable codes. We recently introduced support for overriding retryableCodes in pull settings (#670). However, this property can only be set globally. This PR enables subscription-specific configuration.The retryableCodes configuration can be set in the following manner: Global `spring.cloud.gcp.pubsub.subscriber.retryableCodes=INTERNAL, ABORTED` Subscription-specific `spring.cloud.gcp.pubsub.subscription.mySubscription.retryableCodes=INTERNAL, ABORTED`
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this issue
Oct 20, 2022
) Allow overriding Pub/Sub retryableCodes in pull settings (GoogleCloudPlatform#672) Introduces a new configuration property to customize subscriber pull retryable codes. Example: ``` spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL ``` Fixes: GoogleCloudPlatform#670
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this issue
Oct 20, 2022
…tform#706) Support subscription-specific settings for retryable codes. We recently introduced support for overriding retryableCodes in pull settings (GoogleCloudPlatform#670). However, this property can only be set globally. This PR enables subscription-specific configuration.The retryableCodes configuration can be set in the following manner: Global `spring.cloud.gcp.pubsub.subscriber.retryableCodes=INTERNAL, ABORTED` Subscription-specific `spring.cloud.gcp.pubsub.subscription.mySubscription.retryableCodes=INTERNAL, ABORTED`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pub/Sub client library by default retries UNKNOWN, ABORTED and UNAVAILABLE gRPC codes. For certain usecases, also retrying INTERNAL code is useful.
When creating subscriber stub, we should allow property-based overriding of retryable gRPC codes. Client library defaults should apply if custom codes are not provided.
Example of setting retryiable codes through the client library:
The text was updated successfully, but these errors were encountered: