Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding Pub/Sub retryableCodes in pull settings #672

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

meltsufin
Copy link
Member

@meltsufin meltsufin commented Oct 25, 2021

Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL

Fixes: #670.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meltsufin meltsufin merged commit 8753532 into 2.0.4.patch Oct 25, 2021
@meltsufin meltsufin deleted the retryableCodes branch October 25, 2021 18:30
meltsufin added a commit that referenced this pull request Oct 25, 2021
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
meltsufin added a commit that referenced this pull request Oct 25, 2021
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
mpeddada1 pushed a commit that referenced this pull request Oct 26, 2021
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
mpeddada1 added a commit that referenced this pull request Oct 28, 2021
Allow overriding Pub/Sub retryableCodes in pull settings (#672)

Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this pull request Oct 20, 2022
)

Allow overriding Pub/Sub retryableCodes in pull settings (GoogleCloudPlatform#672)

Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: GoogleCloudPlatform#670
prash-mi pushed a commit that referenced this pull request Jun 20, 2023
Bumps [jacoco-maven-plugin](https://togithub.com/jacoco/jacoco) from 0.8.8 to 0.8.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://togithub.com/jacoco/jacoco/releases">jacoco-maven-plugin's releases</a>.</em></p>
<blockquote>
<h2>0.8.10</h2>
<h2>Fixed bugs</h2>
<ul>
<li>Agent should not require configuration of permissions for <code>SecurityManager</code> outside of its <code>codeBase</code> (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1425">#1425</a>).</li>
</ul>
<h2>0.8.9</h2>
<h2>New Features</h2>
<ul>
<li>JaCoCo now officially supports Java 19 and 20 (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1371">#1371</a>, <a href="https://redirect.github.com/jacoco/jacoco/issues/1386">#1386</a>).</li>
<li>Experimental support for Java 21 class files (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1386">#1386</a>).</li>
<li>Add parameter to include the current project in the <code>report-aggregate</code> Maven goal (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1007">#1007</a>).</li>
<li>Component accessors generated by the Java compilers for records are filtered out during generation of report. Contributed by Tesla Zhang (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1393">#1393</a>).</li>
</ul>
<h2>Fixed bugs</h2>
<ul>
<li>Agent should not open <code>java.lang</code> package to unnamed module of the application class loader (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1334">#1334</a>).</li>
</ul>
<h2>Non-functional Changes</h2>
<ul>
<li>JaCoCo now depends on ASM 9.5 (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1299">#1299</a>, <a href="https://redirect.github.com/jacoco/jacoco/issues/1368">#1368</a>, <a href="https://redirect.github.com/jacoco/jacoco/issues/1416">#1416</a>).</li>
<li>JaCoCo build now requires JDK 11 (GitHub <a href="https://redirect.github.com/jacoco/jacoco/issues/1413">#1413</a>).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://togithub.com/jacoco/jacoco/commit/8ea9668fa0272a6649e031f580c04ede04a7f17c"><code>8ea9668</code></a> Prepare release 0.8.10</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/8f1daf972bc193ce0e10ef57000d112ccaaa4c7a"><code>8f1daf9</code></a> AgentModule should set ProtectionDomain when defining classes (<a href="https://redirect.github.com/jacoco/jacoco/issues/1425">#1425</a>)</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/31f16d834819526cf1e8ffbafed4b7e3fe5ed502"><code>31f16d8</code></a> Upgrade ECJ to 3.33.0 (<a href="https://redirect.github.com/jacoco/jacoco/issues/1423">#1423</a>)</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/3d58c42e6b80be9765a385afb44065f91ef48951"><code>3d58c42</code></a> Prepare for next development iteration</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/c0ad7810555f4c19ab8da68e94d4bf9344481564"><code>c0ad781</code></a> Prepare release 0.8.9</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/c561c13f07a544a3a8cd4430c2bb8eae7deea229"><code>c561c13</code></a> Fix validation test for Java 21 (<a href="https://redirect.github.com/jacoco/jacoco/issues/1422">#1422</a>)</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/461ebf312620799a3815807e09cb84e4e43a39aa"><code>461ebf3</code></a> Add validation test for JEP 432: Record Patterns (<a href="https://redirect.github.com/jacoco/jacoco/issues/1415">#1415</a>)</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/5f12145bffb2b965618f9b0f05e73336fbed3f85"><code>5f12145</code></a> Upgrade ASM to 9.5 (<a href="https://redirect.github.com/jacoco/jacoco/issues/1416">#1416</a>)</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/b865890d566c55832def986bb800b0b2f98200de"><code>b865890</code></a> Agent should not open <code>java.lang</code> package to unnamed module of the applicatio...</li>
<li><a href="https://togithub.com/jacoco/jacoco/commit/5bc2fae5cf3500312b003bc2cc13c438a3313c79"><code>5bc2fae</code></a> Upgrade spotless-maven-plugin to 2.35.0 and Eclipse JDT Formatter to 4.27 (<a href="https://redirect.github.com/jacoco/jacoco/issues/1">#1</a>...</li>
<li>Additional commits viewable in <a href="https://togithub.com/jacoco/jacoco/compare/v0.8.8...v0.8.10">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jacoco:jacoco-maven-plugin&package-manager=maven&previous-version=0.8.8&new-version=0.8.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants