Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward porting changes from 2.0.4.patch branch #677

Merged
merged 6 commits into from
Oct 28, 2021
Merged

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 26, 2021

Branch 2.0.4.path adds configuration to specify retryable codes in pull settings.

Fixes #670

meltsufin and others added 2 commits October 26, 2021 12:09
Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: #670.
Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to put you on the hook for this, but could you add happy path unit tests in subscriber factory and pubsub config?

Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as @elefeint said, if you can bump the coverage up, we'd be very grateful. 🙏

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's weird approving partially my own changes, let's have a re-review from @meltsufin

@mpeddada1 mpeddada1 merged commit e6b80e5 into main Oct 28, 2021
@mpeddada1 mpeddada1 deleted the retryable-backport branch October 28, 2021 17:03
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this pull request Oct 20, 2022
)

Allow overriding Pub/Sub retryableCodes in pull settings (GoogleCloudPlatform#672)

Introduces a new configuration property to customize subscriber pull retryable codes.
Example:

```
spring.cloud.gcp.pubsub.subscriber.retryableCodes=UNKNOWN,ABORTED,UNAVAILABLE,INTERNAL
```

Fixes: GoogleCloudPlatform#670
prash-mi pushed a commit that referenced this pull request Jun 20, 2023
Bumps [reactor-bom](https://togithub.com/reactor/reactor) from 2022.0.6 to 2022.0.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://togithub.com/reactor/reactor/releases">reactor-bom's releases</a>.</em></p>
<blockquote>
<h2>2022.0.7</h2>
<p><code>2022.0.7</code> release train is made of:</p>
<ul>
<li>reactor-core <a href="https://togithub.com/reactor/reactor-core/releases/tag/v3.5.6"><code>3.5.6</code></a></li>
<li>reactor-netty <a href="https://togithub.com/reactor/reactor-netty/releases/tag/v1.1.7"><code>1.1.7</code></a></li>
<li>reactor-kafka <a href="https://togithub.com/reactor/reactor-kafka/releases/tag/v1.3.18"><code>1.3.18</code></a></li>
</ul>
<p>These artifacts didn't have any changes</p>
<ul>
<li>reactor-pool <a href="https://togithub.com/reactor/reactor-pool/releases/tag/v1.0.0"><code>1.0.0</code></a></li>
<li>reactor-addons <a href="https://togithub.com/reactor/reactor-addons/releases/tag/v3.5.1"><code>3.5.1</code></a></li>
<li>reactor-kotlin-extensions <a href="https://togithub.com/reactor/reactor-kotlin-extensions/releases/tag/v1.2.2"><code>1.2.2</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://togithub.com/reactor/reactor/commit/107fed8c29d2191eaee771e74ac3251d69854d06"><code>107fed8</code></a> [release] Prepare and release BOM 2022.0.7</li>
<li><a href="https://togithub.com/reactor/reactor/commit/164f522aec68fde2bc2f401631d0cbd16c5eacea"><code>164f522</code></a> Merge-ignore release 2020.0.32 into 2022.0.7</li>
<li><a href="https://togithub.com/reactor/reactor/commit/9cd804d2e4d1129d089b86a281f3468dede819d1"><code>9cd804d</code></a> [release] Back to snapshots, next BOM will be SR 33</li>
<li><a href="https://togithub.com/reactor/reactor/commit/b1412a87bbf1b22f31b18692892a0164658418cd"><code>b1412a8</code></a> [release] Prepare and release BOM 2020.0.32</li>
<li><a href="https://togithub.com/reactor/reactor/commit/7387164d77865aafa5dc0e7d651bb1dbd30cc0af"><code>7387164</code></a> [release] Back to snapshots, next BOM will be SR 7</li>
<li>See full diff in <a href="https://togithub.com/reactor/reactor/compare/2022.0.6...2022.0.7">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=io.projectreactor:reactor-bom&package-manager=maven&previous-version=2022.0.6&new-version=2022.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding Pub/Sub retryableCodes in pull settings
3 participants